Fix NPE in TransModel trip plan query #6961
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As detailed in #6948, there is a regression in the way invalid locations are handled in the plan query.
This PR fixes the regression.
Since Cleanup RouteRequest - make it immutable #6653 it is not possible anymore to build an invalid
RouteRequest
since validation is performed inRouteRequestBuilder
(invalid requests throwRoutingValidationException
).As a consequences some code branches end up with a
null
request that triggers an NPE.This PR fixes the issue by building an empty TripPlan (without itineraries) in the case of an invalid route request.
Additional refactoring: introducing a builder for PlanResponse
Issue
Closes #6948
Unit tests
Added unit tests.
Documentation
No
Changelog
skip