Add validation for visit via locations with coordinates when attempting to link them to graph #6972
Conversation
…cesContainer into LinkingContext
… TemporaryVerticesContainer
…nd TemporaryVerticesContainer
…emporaryVerticesContainer
…e unused temporary edges
…ng.linking package.
optionsome
added
!Technical Debt
|
We need to figure out what to do with the tests. I feel like there are currently too many of them in too many places and a lot of them are not really that well implemented. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6972 +/- ##
=============================================
+ Coverage 72.11% 72.26% +0.14%
- Complexity 19764 19912 +148
=============================================
Files 2151 2160 +9
Lines 80008 80231 +223
Branches 8072 8093 +21
=============================================
+ Hits 57698 57976 +278
+ Misses 19455 19398 -57
- Partials 2855 2857 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| private LinkingContext createLinkingContext(TemporaryVerticesContainer container) { | ||
| var linkingRequest = LinkingContextRequestMapper.map(request); | ||
| return serverContext.linkingContextFactory().create(container, linkingRequest); |
There was a problem hiding this comment.
I put this factory in the server context. I'm a bit on the edge if it actually made sense or not.
application/src/test/java/org/opentripplanner/routing/core/TemporaryVerticesContainerTest.java
Outdated
Show resolved
Hide resolved
| * are no longer needed, this class removes the temporary vertices and edges. It implements | ||
| * AutoCloseable and the cleanup is automatically done with a try-with-resources statement. | ||
| */ | ||
| public class TemporaryVerticesContainer implements AutoCloseable { |
There was a problem hiding this comment.
Technically this includes edges, not vertices and it disposes both. Not sure if we should rename it.
optionsome
force-pushed
the
temporary-vertex-refactor
branch
from
9bc41a7 to
172389b
Compare
2 participants
Summary
This continues the work from #6704
Temporary vertex creation is moved to routing worker so we don't do it separately for access/egress and direct searches. TemporaryVerticesContainer is now used for coordinate visit via locations as well.
Functional changes:
Issue
Relates to #6501
Unit tests
The testing situation should be refactored.
Documentation
Not needed
Changelog
Skipped