Skip to content

Conversation

leonardehrenfried
Copy link
Member

@leonardehrenfried leonardehrenfried commented Oct 17, 2025

Summary

Implements the following GTFS FaresV2 time limits:

  • type 0: departure to arrival
  • type 1: departure to departure (relevant for TriMet)

This is almost pure sandbox code, with the exception of a some mapping code in the core.

Unit tests

Lots added.

Documentation

Javadoc.

Changelog

No, since it's a sandbox feature.

Bumping the serialization version id

Yes.

cc @miles-grant-ibigroup

@leonardehrenfried leonardehrenfried added this to the 2.9 (next release) milestone Oct 17, 2025
@leonardehrenfried leonardehrenfried requested a review from a team as a code owner October 17, 2025 11:08
@leonardehrenfried leonardehrenfried added !Improvement A functional improvement or micro feature +Sandbox This will be implemented as a Sandbox feature +Skip Changelog This is not a relevant change for a product owner since last release. labels Oct 17, 2025
@leonardehrenfried leonardehrenfried added the +Bump Serialization Id Add this label if you want the serialization id automatically bumped after merging the PR label Oct 17, 2025
Copy link

codecov bot commented Oct 17, 2025

Codecov Report

❌ Patch coverage is 83.78378% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.20%. Comparing base (97aed0d) to head (6735c80).
⚠️ Report is 1 commits behind head on dev-2.x.

Files with missing lines Patch % Lines
...ipplanner/gtfs/mapping/FareTransferRuleMapper.java 55.55% 3 Missing and 1 partial ⚠️
...ntripplanner/ext/fares/model/FareTransferRule.java 80.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             dev-2.x    #6980   +/-   ##
==========================================
  Coverage      72.19%   72.20%           
- Complexity     19838    19854   +16     
==========================================
  Files           2155     2156    +1     
  Lines          80044    80080   +36     
  Branches        8082     8086    +4     
==========================================
+ Hits           57789    57821   +32     
- Misses         19407    19409    +2     
- Partials        2848     2850    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still seeing some incorrect dependentFareProducts created, but this might be a data issue. I still think the PR is worth reviewing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

+Bump Serialization Id Add this label if you want the serialization id automatically bumped after merging the PR !Improvement A functional improvement or micro feature +Sandbox This will be implemented as a Sandbox feature +Skip Changelog This is not a relevant change for a product owner since last release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants