-
Notifications
You must be signed in to change notification settings - Fork 1.1k
GTFS FaresV2 duration limit #6980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev-2.x
Are you sure you want to change the base?
GTFS FaresV2 duration limit #6980
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6980 +/- ##
==========================================
Coverage 72.19% 72.20%
- Complexity 19838 19854 +16
==========================================
Files 2155 2156 +1
Lines 80044 80080 +36
Branches 8082 8086 +4
==========================================
+ Hits 57789 57821 +32
- Misses 19407 19409 +2
- Partials 2848 2850 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still seeing some incorrect dependentFareProducts created, but this might be a data issue. I still think the PR is worth reviewing
Summary
Implements the following GTFS FaresV2 time limits:
This is almost pure sandbox code, with the exception of a some mapping code in the core.
Unit tests
Lots added.
Documentation
Javadoc.
Changelog
No, since it's a sandbox feature.
Bumping the serialization version id
Yes.
cc @miles-grant-ibigroup