Add distance for stop-to-stop shapes, PointsOnLink in Transmodel API #6982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This class is not serialized in OTP and we want to change the class to be lazy-initialized.
…aphQL schema # Conflicts: # application/src/main/java/org/opentripplanner/api/model/geometry/EncodedPolyline.java
t2gran
added
!New Feature
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6982 +/- ##
=============================================
- Coverage 72.19% 72.17% -0.02%
- Complexity 19838 19845 +7
=============================================
Files 2155 2155
Lines 80044 80084 +40
Branches 8082 8084 +2
=============================================
+ Hits 57789 57804 +15
- Misses 19407 19429 +22
- Partials 2848 2851 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
optionsome
requested review from
habrahamsson-skanetrafiken and
jessicaKoehnke
Comment on lines
+298
to
+299
| /// Returns the sum of the distances in between the pairs of coordinates in meters. | ||
| /// If the number of coordinates is empty or just one(a point), then `0` is returned. |
There was a problem hiding this comment.
I haven't seen markdown comments in OTP before, do you think we should start using them even though they're not really supported until java 23?
It will be nice to not have to write html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
distancefield toPointsOnLinkGraphQL type that returns the distance in meters for encoded polyline segmentsEncodedPolylineto compute distance independently from polyline encodingsumDistances(Coordinate[])overload inGeometryUtilsto support distance calculation from coordinate arraysIssue
Closes #6981
Unit tests
Documentation
Changelog
✅ Relevant for changelog
Bumping the serialization version id
🟥 No changes to serialized classes -
EncodedPolylineis not part of the serialized graph model