Replace spotless with Checkstyle and OpenRewrite #6988
+195
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
optionsome
added
the
!Technical Debt
|
There is some new issue related to the text-fixtures. OpenRewrite tries to remove some imports that are actually needed. Not sure if we should move the test classes to slightly different packages to get rid of this problem. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6988 +/- ##
==========================================
Coverage 72.18% 72.18%
- Complexity 19839 19841 +2
==========================================
Files 2155 2155
Lines 80051 80051
Branches 8082 8082
==========================================
+ Hits 57785 57788 +3
+ Misses 19419 19418 -1
+ Partials 2847 2845 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This introduces Checkstyle and OpenRewrite to validate and fix that we don't have unused, duplicate or star imports. OpenRewrite is not run by default. In the future, we will add more rules to Checkstyle and and recipes to OpenRewrite to autofix those issues.
Issue
Related to Helsinki's OTP Summit discussions and #6913.
Unit tests
No
Documentation
Updated
Changelog
Not sure if needed