-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Extract new module street
#7144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
leonardehrenfried
wants to merge
10
commits into
opentripplanner:dev-2.x
Choose a base branch
from
leonardehrenfried:street-module-new
base: dev-2.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Extract new module street
#7144
leonardehrenfried
wants to merge
10
commits into
opentripplanner:dev-2.x
from
leonardehrenfried:street-module-new
+2,512
−1,570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…equest, TransitStopVertex, tests
e77b55b to
efbf9bf
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #7144 +/- ##
=============================================
- Coverage 72.15% 70.04% -2.11%
+ Complexity 20881 20046 -835
=============================================
Files 2273 2273
Lines 84470 84469 -1
Branches 8424 8424
=============================================
- Hits 60952 59170 -1782
- Misses 20544 22333 +1789
+ Partials 2974 2966 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tkalvas
previously approved these changes
Dec 19, 2025
Member
Author
|
Unfortunately this accumulated merge conflicts quickly so I had to merge again. @t2gran let me know if it's still recognisable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
+Bump Serialization Id
Add this label if you want the serialization id automatically bumped after merging the PR
+Skip Changelog
This is not a relevant change for a product owner since last release.
!Technical Debt
Improve code quality, no functional changes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is the second attempt at this. This time round I have split up the work into several commits:
Issue
Ref #6881
Unit tests
Lots updated.
Bumping the serialization version id
Very much yes.