Skip to content

Conversation

@leonardehrenfried
Copy link
Member

Summary

This is the second attempt at this. This time round I have split up the work into several commits:

  • A few small fixes before moving classes
  • Copying test fixtures, because the existing ones are now not on the class path anymore
  • Moving all classes
  • Fixing the imports
  • Updating the architecture tests

Issue

Ref #6881

Unit tests

Lots updated.

Bumping the serialization version id

Very much yes.

@leonardehrenfried leonardehrenfried requested a review from a team as a code owner December 18, 2025 07:13
@leonardehrenfried leonardehrenfried added !Technical Debt Improve code quality, no functional changes. +Bump Serialization Id Add this label if you want the serialization id automatically bumped after merging the PR +Skip Changelog This is not a relevant change for a product owner since last release. labels Dec 18, 2025
@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

❌ Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.04%. Comparing base (1887ed4) to head (8888140).

Files with missing lines Patch % Lines
...ne/config/configure/DeduplicatorServiceModule.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #7144      +/-   ##
=============================================
- Coverage      72.15%   70.04%   -2.11%     
+ Complexity     20881    20046     -835     
=============================================
  Files           2273     2273              
  Lines          84470    84469       -1     
  Branches        8424     8424              
=============================================
- Hits           60952    59170    -1782     
- Misses         20544    22333    +1789     
+ Partials        2974     2966       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

tkalvas
tkalvas previously approved these changes Dec 19, 2025
@leonardehrenfried
Copy link
Member Author

Unfortunately this accumulated merge conflicts quickly so I had to merge again. @t2gran let me know if it's still recognisable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

+Bump Serialization Id Add this label if you want the serialization id automatically bumped after merging the PR +Skip Changelog This is not a relevant change for a product owner since last release. !Technical Debt Improve code quality, no functional changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants