Direct transit search #7145

habrahamsson-skanetrafiken · 2025-12-18T08:41:36Z

Summary

This PR adds support for a complimentary search that is run in addition to the regular raptor search. This new search extends the search result with "direct" transit paths, that is paths with a single transit leg. In contrast to raptor it returns paths even if they are not optimal according to any criteria. It can be configured to run with access/egress or only for stop to stop searches.

The main use case for this additional search is to show slower journeys such as regional trains, slower buses etc that are not included in the main raptor search. See the highlighted journey in the example below, using an ordinary raptor search it will never show up in a search results because the previous journey is better in all criteria.

Issue

Closes #6977. See issue for detailed use cases.

Implementation

The search is implemented in the raptor module and runs on the raptor transit data in order to take advantage of the cost calculation and the itinerary mapping.

Configuration

This feature is currently not exposed through any api and is configurable through router-config.json. It takes three configuration parameters:

costRelaxFunction
In order to exclude really bad paths there is a cost function that is used to reject paths that are much more expensive than the cheapest path.

extraAccessEgressCostFactor
When using this search in an area with lots of transit options such as a city center it can produce too many results where one walks for a while, takes a short transit and then walks to the destination. Having too many of these alternatives will not be useful to travelers. They can be limited using an extra cost on accesses and egresses that is specific for this search.

maxAccessEgressDuration
The maximum length of access/egress, can also be configured to not use access/egress at all. In that case it will only be used when searching to and from a stop or station.

Bumping the serialization version id

Yes, updating the route request.

Co-authored-by: Thomas Gran <[email protected]>

codecov · 2025-12-18T08:48:37Z

Codecov Report

❌ Patch coverage is 31.68605% with 235 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.97%. Comparing base (b0a7a05) to head (64cf3b4).
⚠️ Report is 71 commits behind head on dev-2.x.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...ner/raptor/direct/service/DirectTransitSearch.java	1.12%	88 Missing ⚠️
.../raptor/direct/api/RaptorDirectTransitRequest.java	0.00%	49 Missing ⚠️
...er/transit/mappers/DirectTransitRequestMapper.java	5.12%	36 Missing and 1 partial ⚠️
.../direct/api/RaptorDirectTransitRequestBuilder.java	0.00%	26 Missing ⚠️
...anner/routing/framework/DebugTimingAggregator.java	30.76%	7 Missing and 2 partials ⚠️
.../algorithm/raptoradapter/router/TransitRouter.java	50.00%	6 Missing and 1 partial ⚠️
...r/direct/configure/DirectTransitSearchFactory.java	0.00%	7 Missing ⚠️
...ptoradapter/transit/AccessEgressWithExtraCost.java	0.00%	4 Missing ⚠️
...i/request/preference/DirectTransitPreferences.java	94.23%	1 Missing and 2 partials ⚠️
...ing/api/request/preference/TransitPreferences.java	76.92%	1 Missing and 2 partials ⚠️
... and 2 more

Additional details and impacted files

@@              Coverage Diff              @@
##             dev-2.x    #7145      +/-   ##
=============================================
- Coverage      72.14%   71.97%   -0.17%     
- Complexity     21045    21112      +67     
=============================================
  Files           2292     2305      +13     
  Lines          85036    85569     +533     
  Branches        8473     8526      +53     
=============================================
+ Hits           61349    61592     +243     
- Misses         20713    20993     +280     
- Partials        2974     2984      +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

raptor/src/main/java/org/opentripplanner/raptor/direct/api/RaptorDirectTransitRequest.java

raptor/src/main/java/org/opentripplanner/raptor/direct/service/DirectTransitSearch.java

raptor/src/main/java/org/opentripplanner/raptor/spi/RaptorSlackProvider.java

.../src/main/java/org/opentripplanner/routing/algorithm/raptoradapter/router/TransitRouter.java

...a/org/opentripplanner/routing/algorithm/raptoradapter/transit/AccessEgressWithExtraCost.java

...st/java/org/opentripplanner/routing/api/request/preference/DirectTransitPreferencesTest.java

...main/java/org/opentripplanner/standalone/config/routerequest/DirectTransitRequestConfig.java

raptor/src/main/java/org/opentripplanner/raptor/api/request/RelaxedLimitedTransferRequest.java

...st/java/org/opentripplanner/raptor/moduletests/M02_DirectTransitWithTripsInSearchWindow.java

t2gran · 2026-01-22T22:18:44Z

raptor/src/test/java/org/opentripplanner/raptor/moduletests/M04_RelaxedCostLimit.java

+ * <p>
+ * The direct transit search should include trips within the cost limit
+ */
+public class M04_RelaxedCostLimit implements RaptorTestConstants {


The test description is incorrect. This test is testing departure time and arrival time for optimality.

Not sure I understand the comments on each of the test methods - they seem to focus on arrive/departure times, while the class objective talk about cost. Are arrival & departure times considered?

Ah, I understand what you mean and I tried to clarify the comments. The search will include results if they are optimal on arrival or departure or if they are within the "cost limit". These tests are set up in such a way that arrival and departure times should not influence whether the trip under test gets included or not.

Maye I should just remove the reference to arrival and departure times in the comments.

...st/java/org/opentripplanner/raptor/moduletests/M01_DirectTransitWithRoutesWithinRelaxC1.java

leonardehrenfried · 2026-01-23T10:39:52Z

You need to resolve the conflicts.

raptor/src/test/java/org/opentripplanner/raptor/moduletests/M04_RelaxedCostLimit.java

raptor/src/test/java/org/opentripplanner/raptor/RaptorArchitectureTest.java

raptor/src/test/java/org/opentripplanner/raptor/moduletests/package-info.md

...ntripplanner/routing/algorithm/raptoradapter/transit/mappers/DirectTransitRequestMapper.java

...c/main/java/org/opentripplanner/routing/api/request/preference/DirectTransitPreferences.java

…m/raptoradapter/transit/mappers/DirectTransitRequestMapper.java Co-authored-by: Thomas Gran <[email protected]>

optionsome · 2026-01-30T08:25:25Z

...c/main/java/org/opentripplanner/routing/api/request/preference/DirectTransitPreferences.java

+  @Override
+  public String toString() {
+    return ToStringBuilder.of(DirectTransitPreferences.class)
+      .addBool("enabled", enabled)


Should we only log this when it doesn't match the default?

I think it would be helpful to log it even when it is default (false) since this will cause the direct transit search to be disabled.

optionsome · 2026-01-30T08:29:21Z

...main/java/org/opentripplanner/standalone/config/routerequest/DirectTransitRequestConfig.java

+      )
+      .withCostRelaxFunction(
+        c
+          .of("costRelaxFunction")


What did we decide with this naming? I can't remember anymore.

We decided to leave it like this to keep it consistent with the transit group priority. If we decide to change this to "costLimitFunction" we will do that together with the transit group priority feature.

optionsome · 2026-01-30T11:38:59Z

Formatting is broken.

habrahamsson-skanetrafiken and others added 3 commits December 18, 2025 09:12

feat: Implement RelaxedLimitedTransferSearch

bfe7155

Co-authored-by: Thomas Gran <[email protected]>

feat: Add configuration for RelaxedLimitedTransferSearch

2207936

test: Tests for RelaxedLimitedTransferSearch

4588ff4

habrahamsson-skanetrafiken requested a review from a team as a code owner December 18, 2025 08:41

habrahamsson-skanetrafiken added !New Feature A functional feature targeting the end user. +Bump Serialization Id Add this label if you want the serialization id automatically bumped after merging the PR labels Dec 18, 2025

habrahamsson-skanetrafiken assigned t2gran Dec 18, 2025

habrahamsson-skanetrafiken requested a review from t2gran December 18, 2025 08:42

feat: Implement direct transit search and refactor related components

6081246

t2gran force-pushed the relaxed-limited-transfer-search branch from 81feadd to 6081246 Compare January 12, 2026 11:43

habrahamsson-skanetrafiken added 3 commits January 12, 2026 14:55

feat: Add debug timers

86a578e

feat: Remove opening hour access/egress from direct transit search

b6a90f3

Fix build

bad1eed

habrahamsson-skanetrafiken changed the title ~~Relaxed limited transfer search~~ Direct transit search Jan 12, 2026

habrahamsson-skanetrafiken added 5 commits January 13, 2026 14:30

Fix test

1bd2aaa

Regen doc

14c38fd

restore the enabled configuration flag

56f75f0

fix: Fix for direct transit results not showing up

9552764

change disableAcessEgress to maxAccessEgressDuration

8f2ecc2

habrahamsson-skanetrafiken commented Jan 15, 2026

View reviewed changes

raptor/src/main/java/org/opentripplanner/raptor/direct/api/RaptorDirectTransitRequest.java Show resolved Hide resolved

habrahamsson-skanetrafiken added 2 commits January 15, 2026 12:55

Remove unused code

5bcfb71

Add some documentation

57f1220

habrahamsson-skanetrafiken commented Jan 15, 2026

View reviewed changes

raptor/src/main/java/org/opentripplanner/raptor/direct/api/RaptorDirectTransitRequest.java Outdated Show resolved Hide resolved

habrahamsson-skanetrafiken and others added 3 commits January 20, 2026 12:56

Minor changes to RaptorDirectTransitRequest

02ad356

Dont run search if access/egress is empty

bdc915c

refactor: Remove unused RelaxedLimitedTransferRequest and rename test.

3e525f4

t2gran requested changes Jan 22, 2026

View reviewed changes

t2gran added this to the 2.9 (next release) milestone Jan 23, 2026

habrahamsson-skanetrafiken commented Jan 23, 2026

View reviewed changes

raptor/src/test/java/org/opentripplanner/raptor/moduletests/M04_RelaxedCostLimit.java Outdated Show resolved Hide resolved

habrahamsson-skanetrafiken commented Jan 23, 2026

View reviewed changes

raptor/src/test/java/org/opentripplanner/raptor/RaptorArchitectureTest.java Outdated Show resolved Hide resolved

refactor: Skip trips in trip-search for direct transit search

30a9e4c

optionsome reviewed Jan 23, 2026

View reviewed changes

raptor/src/test/java/org/opentripplanner/raptor/moduletests/package-info.md Outdated Show resolved Hide resolved

habrahamsson-skanetrafiken added 5 commits January 27, 2026 10:18

refactor: Separate mapping logic

9527457

Fix documentation

59f8755

refactor: Rename CostFactor to Reluctance

8221011

Update preferences object

75be5cf

Adress review comments

2fef52c

habrahamsson-skanetrafiken requested review from optionsome and t2gran January 27, 2026 12:29

t2gran reviewed Jan 29, 2026

View reviewed changes

...ntripplanner/routing/algorithm/raptoradapter/transit/mappers/DirectTransitRequestMapper.java Outdated Show resolved Hide resolved

t2gran requested changes Jan 29, 2026

View reviewed changes

...c/main/java/org/opentripplanner/routing/api/request/preference/DirectTransitPreferences.java Show resolved Hide resolved

habrahamsson-skanetrafiken and others added 2 commits January 29, 2026 14:07

Update application/src/main/java/org/opentripplanner/routing/algorith…

4cb1c54

…m/raptoradapter/transit/mappers/DirectTransitRequestMapper.java Co-authored-by: Thomas Gran <[email protected]>

Add constructor non-null validation

bf33980

habrahamsson-skanetrafiken requested a review from t2gran January 29, 2026 13:13

t2gran previously approved these changes Jan 29, 2026

View reviewed changes

Fix nullable parameter

4c2df61

habrahamsson-skanetrafiken dismissed t2gran’s stale review via 4c2df61 January 29, 2026 15:38

habrahamsson-skanetrafiken requested a review from t2gran January 29, 2026 15:44

t2gran previously approved these changes Jan 29, 2026

View reviewed changes

optionsome reviewed Jan 30, 2026

View reviewed changes

habrahamsson-skanetrafiken requested a review from optionsome January 30, 2026 09:44

Don't log the enabled flag when default

46fe8ee

habrahamsson-skanetrafiken dismissed t2gran’s stale review via 46fe8ee January 30, 2026 10:10

habrahamsson-skanetrafiken requested a review from t2gran January 30, 2026 10:11

refactor: Only log DirectTransitPreferences when not default

4fc568a

Fix formatting

64cf3b4

optionsome approved these changes Jan 30, 2026

View reviewed changes

Direct transit search #7145

Are you sure you want to change the base?

Direct transit search #7145

Uh oh!

Conversation

habrahamsson-skanetrafiken commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Issue

Implementation

Configuration

Bumping the serialization version id

Uh oh!

codecov bot commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

t2gran Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

habrahamsson-skanetrafiken Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

t2gran Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

habrahamsson-skanetrafiken Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

leonardehrenfried commented Jan 23, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

optionsome Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

habrahamsson-skanetrafiken Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

optionsome Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

habrahamsson-skanetrafiken Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

optionsome commented Jan 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

habrahamsson-skanetrafiken commented Dec 18, 2025 •

edited

Loading

codecov bot commented Dec 18, 2025 •

edited

Loading

t2gran Jan 23, 2026 •

edited

Loading