Update constrained transfers after realtime stop pattern is changed #7147
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a follow up on #7052 and #7146. In the Raptor adaptor the constrained transfers are regenerated for all trips with real-time updates. The previous code did not include added/extra journey. The code is still probably wrong, but at least the error not silently ignored.
Note! In NeTEx (nordic profile) a interchange is not allowed on a Line or Stop, like it is in GTFS. Since interchanges are defined in scheduled data, a trip appearing in real-time can not have any interchanges. For GTFS this is a potensial problem, but we strongly recommend avoiding defining transfers on route and stop level.
Unit tests
This code has very little tests and none of the existing tests broke after changing the code. No new tests are added since we want to replace this with a different strategy. We also want to gather more experience with this by observing the loggs, before we fix any thing.
Documentation
A little more doc is added to the code.
Changelog
🟥 This is a follow up on #7052, it should be enough to mention the main issue/PR in the change log.
Bumping the serialization version id
🟥 Not needed, but this is build on top of #7052 and #7146, so we will temporarlly set the label - until 7052 i merged.