Skip to content

Conversation

@t2gran
Copy link
Member

@t2gran t2gran commented Dec 18, 2025

Summary

This is a follow up on #7052 and #7146. In the Raptor adaptor the constrained transfers are regenerated for all trips with real-time updates. The previous code did not include added/extra journey. The code is still probably wrong, but at least the error not silently ignored.

Note! In NeTEx (nordic profile) a interchange is not allowed on a Line or Stop, like it is in GTFS. Since interchanges are defined in scheduled data, a trip appearing in real-time can not have any interchanges. For GTFS this is a potensial problem, but we strongly recommend avoiding defining transfers on route and stop level.

Unit tests

This code has very little tests and none of the existing tests broke after changing the code. No new tests are added since we want to replace this with a different strategy. We also want to gather more experience with this by observing the loggs, before we fix any thing.

Documentation

A little more doc is added to the code.

Changelog

🟥 This is a follow up on #7052, it should be enough to mention the main issue/PR in the change log.

Bumping the serialization version id

🟥 Not needed, but this is build on top of #7052 and #7146, so we will temporarlly set the label - until 7052 i merged.

This is needed to show extra journeys (added trips) on arrival/depature boards
The existing code only remove real time trip updates with modified stop-patterns, not added trips(NeTEx ExtraJourney). If an ExtraJourney is canceled, the first update is not removed.
@t2gran t2gran added !Bug Apply to issues describing a bug and PRs witch fixes it. +Bump Serialization Id Add this label if you want the serialization id automatically bumped after merging the PR +Skip Changelog This is not a relevant change for a product owner since last release. Entur Test This is currently being tested at Entur labels Dec 18, 2025
@t2gran t2gran added this to the 2.9 (next release) milestone Dec 18, 2025
@t2gran t2gran removed the Entur Test This is currently being tested at Entur label Dec 19, 2025
@codecov
Copy link

codecov bot commented Dec 19, 2025

Codecov Report

❌ Patch coverage is 88.46154% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.09%. Comparing base (e5ddac1) to head (5f8152e).
⚠️ Report is 1 commits behind head on dev-2.x.

Files with missing lines Patch % Lines
...tripplanner/transit/model/network/TripPattern.java 71.42% 1 Missing and 1 partial ⚠️
...nsit/mappers/RealTimeRaptorTransitDataUpdater.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #7147      +/-   ##
=============================================
- Coverage      72.10%   72.09%   -0.01%     
  Complexity     20701    20701              
=============================================
  Files           2245     2245              
  Lines          83914    83925      +11     
  Branches        8347     8348       +1     
=============================================
+ Hits           60503    60509       +6     
- Misses         20482    20484       +2     
- Partials        2929     2932       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

!Bug Apply to issues describing a bug and PRs witch fixes it. +Bump Serialization Id Add this label if you want the serialization id automatically bumped after merging the PR +Skip Changelog This is not a relevant change for a product owner since last release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants