Skip to content

Conversation

@testower
Copy link
Contributor

Summary

Creates a sandbox that processes GBFS geofencing zones at graph build time

Issue

Closes #7120

Unit tests

TBD

Documentation

TBD

Bumping the serialization version id

Yes this needs a new serialization version because we added GeofencingZone and RentalRestrictionExtension to the graph.

@testower testower added +Sandbox This will be implemented as a Sandbox feature +Bump Serialization Id Add this label if you want the serialization id automatically bumped after merging the PR labels Dec 22, 2025
@testower testower force-pushed the poc/sandbox-geofencing-zones-in-graph-builder branch from 312368c to d56b9ba Compare December 22, 2025 14:22
@codecov
Copy link

codecov bot commented Dec 22, 2025

Codecov Report

❌ Patch coverage is 5.75221% with 213 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.98%. Comparing base (1887ed4) to head (d56b9ba).

Files with missing lines Patch % Lines
...ernal/graphbuilder/GbfsGeofencingGraphBuilder.java 0.00% 53 Missing ⚠️
...g/internal/graphbuilder/GeofencingZoneApplier.java 0.00% 51 Missing ⚠️
...ng/internal/graphbuilder/GeofencingZoneMapper.java 0.00% 31 Missing ⚠️
...xt/gbfsgeofencing/config/GbfsGeofencingConfig.java 24.13% 21 Missing and 1 partial ⚠️
...fsgeofencing/internal/graphbuilder/GbfsClient.java 0.00% 21 Missing ⚠️
...cing/internal/DefaultGbfsGeofencingRepository.java 0.00% 9 Missing ⚠️
...ncing/parameters/GbfsGeofencingFeedParameters.java 0.00% 6 Missing ⚠️
...ng/configure/GbfsGeofencingGraphBuilderModule.java 0.00% 4 Missing ⚠️
...cing/configure/GbfsGeofencingRepositoryModule.java 0.00% 4 Missing ⚠️
...eofencing/parameters/GbfsGeofencingParameters.java 40.00% 2 Missing and 1 partial ⚠️
... and 5 more
Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #7155      +/-   ##
=============================================
- Coverage      72.15%   71.98%   -0.18%     
- Complexity     20881    20887       +6     
=============================================
  Files           2273     2284      +11     
  Lines          84470    84695     +225     
  Branches        8424     8444      +20     
=============================================
+ Hits           60952    60967      +15     
- Misses         20544    20754     +210     
  Partials        2974     2974              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

+Bump Serialization Id Add this label if you want the serialization id automatically bumped after merging the PR +Sandbox This will be implemented as a Sandbox feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Load GBFS Geofencing Zones at Graph Build Time as a Sandbox

1 participant