Update prettier-java version #7164
Conversation
Co-authored-by: Thomas Gran <[email protected]>
optionsome
added
!Technical Debt
|
jhipster/prettier-java#780 caused some formatting changes that we are not happy with as it moved some comments to be trailing comments when previously they were before on own line inside a ternary operation. However, I only had to fix those kinds of problems in three places and when it happens, checkstyle will fail. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #7164 +/- ##
===========================================
Coverage 72.17% 72.18%
- Complexity 20877 20923 +46
===========================================
Files 2273 2273
Lines 84437 84678 +241
Branches 8424 8425 +1
===========================================
+ Hits 60942 61123 +181
- Misses 20520 20578 +58
- Partials 2975 2977 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| "the start location (`from`) to the first entry in the `via` locations list and the " + | ||
| "last is from the last entry in the `via` locations list to the end location (`to`). " + | ||
| "Note that the list must have length of exactly one greater than the `via` field." | ||
| "the start location (`from`) to the first entry in the `via` locations list and the " + | ||
| "last is from the last entry in the `via` locations list to the end location (`to`). " + | ||
| "Note that the list must have length of exactly one greater than the `via` field." |
There was a problem hiding this comment.
There are a lot of these kinds of changes which can lead to some lines going slightly over the line width limit (by 1-2 characters) as we have previously manually made sure they fit in the line width and now prettier moves them to the right by a couple of characters.
| // next iteration (looking at the boarding of the current transit leg). The transfer with the | ||
| // earliest-arrival-time BEFORE the transit-leg is used to prune the transfers AFTER the | ||
| // transit-leg. The transfers are sorted on arrival-time in descending order, so the | ||
| // earliest-arrival-time is the last element of the list of transfers. | ||
| int earliestDepartureTimeFromLeg = i == 0 | ||
| ? accessArrivalTime | ||
| // The transfer with the earliest-arrival-time BEFORE the transit-leg is used to | ||
| // prune the transfers AFTER the transit-leg. The transfers are sorted on | ||
| // arrival-time in descending order, so the earliest-arrival-time is the | ||
| // last element of the list of transfers. | ||
| : last(possibleTransfers.get(i - 1)).to().time(); |
There was a problem hiding this comment.
This is the type of a ternary operation change mentioned in #7164 (comment) that I have manually fixed.
1 participant
Summary
Updates prettier-java version to 2.7.7 and re-formats code based on updated prettier formatting.
This is currently built on top of #7138. This pr is currently open to demonstrate the changes. If we decide we want to update prettier, we should wait until #7138 is merged and then re-format the code with the latest upstream version and merge the changes in quickly before there are conflicts.
Issue
No issue
Unit tests
No functional updates
Documentation
No updates
Changelog
Skipped