Skip to content

Conversation

@leonardehrenfried
Copy link
Member

@leonardehrenfried leonardehrenfried commented Jan 12, 2026

Summary

  • Implements OJP (Open Journey Planner) API as a sandbox feature for StopEventRequest and TripRequest
  • Implements transit filters (agency, mode, personal mode)
  • Adds comprehensive mapping between OJP requests and OTP routing

Issue

Closes #2753

Even though this only implements part of OJP, lets close the issue and open new ones for more features.

Unit tests

The mapping of the route request is tested extensively.

Documentation

Sandbox doc.

Changelog

Skip, because it's sandbox.

Bumping the serialization version id

Yes.

@leonardehrenfried leonardehrenfried requested a review from a team as a code owner January 12, 2026 06:49
@leonardehrenfried leonardehrenfried added +Sandbox This will be implemented as a Sandbox feature +Bump Serialization Id Add this label if you want the serialization id automatically bumped after merging the PR +Skip Changelog This is not a relevant change for a product owner since last release. labels Jan 12, 2026
@leonardehrenfried leonardehrenfried changed the title Ojp OJP's StopEventRequest and TripRequest Jan 12, 2026
@leonardehrenfried
Copy link
Member Author

cc @fahrplaner

@codecov
Copy link

codecov bot commented Jan 12, 2026

Codecov Report

❌ Patch coverage is 66.56101% with 211 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.12%. Comparing base (4639397) to head (dc8c618).
⚠️ Report is 36 commits behind head on dev-2.x.

Files with missing lines Patch % Lines
...va/org/opentripplanner/ext/ojp/RequestHandler.java 0.00% 32 Missing ⚠️
...rg/opentripplanner/ext/ojp/service/OjpService.java 0.00% 31 Missing ⚠️
...ripplanner/ext/ojp/mapping/TripResponseMapper.java 77.08% 18 Missing and 4 partials ⚠️
.../opentripplanner/ext/ojp/resource/OjpResource.java 0.00% 20 Missing ⚠️
...ripplanner/ext/ojp/mapping/RouteRequestMapper.java 86.04% 14 Missing and 4 partials ⚠️
...org/opentripplanner/ext/ojp/resource/OjpCodec.java 0.00% 17 Missing ⚠️
...pentripplanner/ext/ojp/resource/TriasResource.java 0.00% 14 Missing ⚠️
...ner/ext/ojp/mapping/TripResponseContextMapper.java 68.57% 9 Missing and 2 partials ⚠️
...tripplanner/ext/ojp/service/CallAtStopService.java 81.48% 4 Missing and 6 partials ⚠️
...ripplanner/ext/ojp/mapping/PersonalModeMapper.java 25.00% 7 Missing and 2 partials ⚠️
... and 13 more
Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #7186      +/-   ##
=============================================
- Coverage      72.15%   72.12%   -0.04%     
- Complexity     21089    21198     +109     
=============================================
  Files           2297     2315      +18     
  Lines          85218    85680     +462     
  Branches        8483     8511      +28     
=============================================
+ Hits           61487    61794     +307     
- Misses         20753    20893     +140     
- Partials        2978     2993      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

+Bump Serialization Id Add this label if you want the serialization id automatically bumped after merging the PR +Sandbox This will be implemented as a Sandbox feature +Skip Changelog This is not a relevant change for a product owner since last release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement OpenJourneyPlanner (OJP) query and serialisation format

3 participants