Skip to content

Conversation

@t2gran
Copy link
Member

@t2gran t2gran commented Jan 15, 2026

Summary

This PR add a publiccode.yml file to the project. This is recommended for Open Source projects in used by public agencies in the European Union. See https://interoperable-europe.ec.europa.eu/collection/open-source-observatory-osor/publiccodeyml-standard.

In the listing of deployments, I have listed the most significant European deployments, there is a link to the OTP doc where we list all "known" deployments.

Issue

No

Unit tests

Not relevant

Documentation

✅ This make OTP searchable for Open-Source search-boots, and can potentially be use to list OTP in Open Source Repositories

Changelog

✅ Yes

Bumping the serialization version id

🟥 Not relevant

@t2gran t2gran added this to the 2.9 (next release) milestone Jan 15, 2026
@t2gran t2gran requested a review from a team as a code owner January 15, 2026 23:53
@t2gran t2gran added the !Documentation Improve documentation targeting users and/or developers. label Jan 15, 2026
@codecov
Copy link

codecov bot commented Jan 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.12%. Comparing base (5d7363c) to head (b51e0bb).
⚠️ Report is 186 commits behind head on dev-2.x.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #7212      +/-   ##
=============================================
+ Coverage      72.07%   72.12%   +0.04%     
- Complexity     20907    21082     +175     
=============================================
  Files           2282     2297      +15     
  Lines          84459    85223     +764     
  Branches        8433     8487      +54     
=============================================
+ Hits           60873    61463     +590     
- Misses         20617    20780     +163     
- Partials        2969     2980      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Co-authored-by: Joel Lappalainen <[email protected]>
Co-authored-by: Leonard Ehrenfried <[email protected]>
Copy link
Contributor

@VillePihlava VillePihlava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a look and found some things. Some comments are more observations than request changes

publiccode.yml Outdated
Comment on lines 27 to 29
- Finland, Helsinki, Helsinki Regional Transport Authority
- Finland (nationwide), Finnish Transport Agency
- Finland Intercity, Matkahuolto
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://yml.publiccode.tools/schema.core.html#key-usedby

A list of the names of prominent public administrations (that will serve as “testimonials”) that are currently known to the software maintainer to be using this software.

The Digitransit project is funded by public authorities through Fintraffic, HSL, and Waltti. Matkahuolto is a private company, so I would remove it. Although it probably isn't that bad if they all aren't public administrations

Suggested change
- Finland, Helsinki, Helsinki Regional Transport Authority
- Finland (nationwide), Finnish Transport Agency
- Finland Intercity, Matkahuolto
- Finland, Helsinki, Helsinki Region Transport Authority (HSL)
- Finland (nationwide), Fintraffic
- Finland (various cities), Waltti Solutions

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you or Joule update the https://docs.opentripplanner.org/en/latest/Deployments ?

I have made the changes to the publiccode.yml.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll update them

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it is the Digitransit project witch sponsor OTP, not the listed ones ;-)

I copied the existing fields into https://publiccode-editor.developers.italia.it/?countrySpecific=italy, made a few changes from the review and generate and validated the file.
Copy link
Contributor

@VillePihlava VillePihlava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple small things. Other than these I think this is ready

Comment on lines +27 to +29
- Finland, Helsinki, Helsinki Region Transport Authority
- Finland (nationwide), Fintraffic
- Finland (various cities), Waltti Solutions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for consistency, the HSL abbreviation isn't clear from the English name

Suggested change
- Finland, Helsinki, Helsinki Region Transport Authority
- Finland (nationwide), Fintraffic
- Finland (various cities), Waltti Solutions
- Finland, Helsinki, Helsinki Region Transport Authority (HSL)
- Finland (nationwide), Fintraffic
- Finland (various cities), Waltti Solutions

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is HSL part of the name? We are not including abravation, short names or marketing names for other authorities. So, I would prefer not to do it for HSL as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason many websites manage to spell HSL in English differently. Lets go with Helsinki Region Transport.

Many websites do include the Finnish abbreviation as well (HSL), e.g., https://waltti.fi/en/cities/helsinki-region-transport/, https://www.hel.fi/en/urban-environment-and-traffic/getting-around-helsinki-tips-for-newcomers, and https://futuremobilityfinland.fi/organizations/hsl-helsinki-region-transport-efficient-and-sustainable-public-transport-in-the-helsinki-region/. However, if we don't provide abbreviations for others, I guess we can also not include it for HSL.

Copy link
Contributor

@VillePihlava VillePihlava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small fixes

Comment on lines +23 to +26
- name: Helsinki Regional Transport Authority
uri: https://www.hsl.fi
- name: Wallti Solutions
uri: https://waltti.fi/en/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: Helsinki Regional Transport Authority
uri: https://www.hsl.fi
- name: Wallti Solutions
uri: https://waltti.fi/en/
- name: Helsinki Region Transport
uri: https://www.hsl.fi/en
- name: Waltti Solutions
uri: https://waltti.fi/en/

- Finland, Helsinki, Helsinki Region Transport Authority
- Finland (nationwide), Fintraffic
- Finland (various cities), Waltti Solutions
- Finland (nationwide), Matkahuolto
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A list of the names of prominent public administrations (that will serve as “testimonials”) that are currently known to the software maintainer to be using this software.

Can you remove this, I think Brede accidentally added it back

Suggested change
- Finland (nationwide), Matkahuolto

@t2gran
Copy link
Member Author

t2gran commented Jan 29, 2026

There has been a little back an forth when it comes to the fundedBy list.

We do not want to list all contributors to OTP - the list is too long and hard to maintain, so the goal is to make a cut we can explain and not skip some of the larger contributing organisations.

We would like to fokus on:

  • Listing the main contributions with regard to work(PRs)
  • Also, look at the funding (money).
  • Focus on European organisations, since the goal of adding the publiccode.yml is to be listed in EU repositories listing OSS for public agencies.
  • Not sure if we want to look at the current contributors or historic contributors - probably both, but favour current.

The long list of contributors/deployments is here: https://docs.opentripplanner.org/en/latest/Deployments/

We are waiting for Thomas C here, we should also check with @abyrd on this.

- name: Thomas Gran
email: [email protected]
affiliation: Entur AS
- name: Leonard Ehrenfried
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sweco-semkni Seems like I'm already here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

!Documentation Improve documentation targeting users and/or developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants