Skip to content

Conversation

@optionsome
Copy link
Member

Summary

Previously via visit locations had to be between transit legs. This pr allows them to be also in accesses or egresses.

Built on top of #7105

Issue

Relates to #4887

Unit tests

TODO

Documentation

Not needed

Changelog

From title

@optionsome optionsome added this to the 2.9 (next release) milestone Jan 26, 2026
@optionsome optionsome added the !Improvement A functional improvement or micro feature label Jan 26, 2026
@codecov
Copy link

codecov bot commented Jan 26, 2026

Codecov Report

❌ Patch coverage is 31.23596% with 306 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.94%. Comparing base (9afdb15) to head (8ca066a).
⚠️ Report is 4 commits behind head on dev-2.x.

Files with missing lines Patch % Lines
...oradapter/router/street/ViaAccessEgressRouter.java 0.00% 136 Missing ⚠️
...oradapter/router/street/ViaDirectStreetRouter.java 0.00% 115 Missing ⚠️
.../opentripplanner/routing/impl/GraphPathFinder.java 54.54% 8 Missing and 2 partials ⚠️
...r/routing/algorithm/mapping/ItinerariesHelper.java 12.50% 7 Missing ⚠️
...aptoradapter/router/street/DirectStreetRouter.java 80.00% 3 Missing and 3 partials ⚠️
...entripplanner/apis/gtfs/datafetchers/StopImpl.java 0.00% 4 Missing ⚠️
...src/main/java/org/opentripplanner/astar/AStar.java 0.00% 4 Missing ⚠️
...apter/router/street/AccessEgressRouterFactory.java 25.00% 2 Missing and 1 partial ⚠️
...pentripplanner/routing/graphfinder/NearbyStop.java 78.57% 2 Missing and 1 partial ⚠️
...rg/opentripplanner/visualizer/GraphVisualizer.java 0.00% 3 Missing ⚠️
... and 11 more
Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #7239      +/-   ##
=============================================
- Coverage      72.14%   71.94%   -0.21%     
- Complexity     21086    21102      +16     
=============================================
  Files           2297     2303       +6     
  Lines          85223    85504     +281     
  Branches        8487     8503      +16     
=============================================
+ Hits           61488    61518      +30     
- Misses         20752    21003     +251     
  Partials        2983     2983              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

!Improvement A functional improvement or micro feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant