-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add support for via coordinates in accesses and egresses #7239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
optionsome
wants to merge
15
commits into
opentripplanner:dev-2.x
Choose a base branch
from
HSLdevcom:access-egress-via-routing
base: dev-2.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add support for via coordinates in accesses and egresses #7239
optionsome
wants to merge
15
commits into
opentripplanner:dev-2.x
from
HSLdevcom:access-egress-via-routing
+1,233
−378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… singular last state
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #7239 +/- ##
=============================================
- Coverage 72.14% 71.94% -0.21%
- Complexity 21086 21102 +16
=============================================
Files 2297 2303 +6
Lines 85223 85504 +281
Branches 8487 8503 +16
=============================================
+ Hits 61488 61518 +30
- Misses 20752 21003 +251
Partials 2983 2983 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously via visit locations had to be between transit legs. This pr allows them to be also in accesses or egresses.
Built on top of #7105
Issue
Relates to #4887
Unit tests
TODO
Documentation
Not needed
Changelog
From title