-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add ability to start a Raptor search from on-board a trip in MC range raptor #7241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev-2.x
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #7241 +/- ##
=============================================
+ Coverage 72.12% 72.15% +0.03%
- Complexity 21017 21129 +112
=============================================
Files 2288 2299 +11
Lines 84881 85345 +464
Branches 8461 8504 +43
=============================================
+ Hits 61221 61582 +361
- Misses 20686 20774 +88
- Partials 2974 2989 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
078daf3 to
f3e327d
Compare
f3e327d to
bcb161a
Compare
7b3c2ce to
a5d1855
Compare
a5d1855 to
3d8648a
Compare
raptor/src/main/java/org/opentripplanner/raptor/api/view/OnBoardTripConstraint.java
Show resolved
Hide resolved
| void findOnBoardAccessForRound(int iterationDepartureTime); | ||
|
|
||
| /** | ||
| * Perform on-board (accesses on-board an already started trip) transit search for boardings and | ||
| * alight events for the current round. | ||
| */ | ||
| void findOnBoardAccessTransitForRound(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The names are a bit confusing, maybe we should make a follow up PR and try to improve some of the naming. The method names follow the naming conventions as existing methods so we should change all methods at the same time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed to do this, along with rewording the other methods in this worker for consistency in a follow-up PR. A follow up PR is preferred to keep that refactor isolated and easy to review.
Summary
This PR adds functionality for starting a raptor search on-board a trip. It is scoped to the multi-criteria raptor in the forward direction.
Issue
#7175
Unit tests
dev-2.xand verify there's no performance impact on standard operationDocumentation
Javadoc