Skip to content

Conversation

@sigtot
Copy link

@sigtot sigtot commented Jan 26, 2026

Summary

This PR adds functionality for starting a raptor search on-board a trip. It is scoped to the multi-criteria raptor in the forward direction.

Issue

#7175

Unit tests

  • New unit tests added at the level of the RaptorService to verify that an on-board access has the intended behavior. No other tests have been modified.
  • Performance tests for Norway run locally to compare against dev-2.x and verify there's no performance impact on standard operation

Documentation

Javadoc

@sigtot sigtot added the Entur On Entur Roadmap label Jan 26, 2026
@codecov
Copy link

codecov bot commented Jan 26, 2026

Codecov Report

❌ Patch coverage is 81.81818% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.15%. Comparing base (352a626) to head (4ee6bba).
⚠️ Report is 119 commits behind head on dev-2.x.

Files with missing lines Patch % Lines
...r/raptor/rangeraptor/DefaultRangeRaptorWorker.java 85.10% 2 Missing and 5 partials ⚠️
...or/multicriteria/MultiCriteriaRoutingStrategy.java 66.66% 2 Missing and 2 partials ⚠️
...aptor/rangeraptor/internalapi/RoutingStrategy.java 33.33% 2 Missing ⚠️
...r/multicriteria/arrivals/c1/AccessStopArrival.java 66.66% 1 Missing and 1 partial ⚠️
...raptor/transit/ForwardRaptorTransitCalculator.java 66.66% 1 Missing and 1 partial ⚠️
...raptor/transit/ReverseRaptorTransitCalculator.java 66.66% 1 Missing and 1 partial ⚠️
...pplanner/raptor/api/model/RaptorOnBoardAccess.java 83.33% 1 Missing ⚠️
...g/opentripplanner/raptor/api/view/ArrivalView.java 0.00% 1 Missing ⚠️
...tor/rangeraptor/transit/AccessEgressFunctions.java 80.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #7241      +/-   ##
=============================================
+ Coverage      72.12%   72.15%   +0.03%     
- Complexity     21017    21129     +112     
=============================================
  Files           2288     2299      +11     
  Lines          84881    85345     +464     
  Branches        8461     8504      +43     
=============================================
+ Hits           61221    61582     +361     
- Misses         20686    20774      +88     
- Partials        2974     2989      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sigtot sigtot force-pushed the raptor-on-board-access branch 5 times, most recently from 078daf3 to f3e327d Compare January 28, 2026 12:43
@sigtot sigtot added the +Integration Test Activate the integration tests on PR label Jan 28, 2026
@sigtot sigtot force-pushed the raptor-on-board-access branch from f3e327d to bcb161a Compare January 28, 2026 12:58
@sigtot sigtot removed the +Integration Test Activate the integration tests on PR label Jan 28, 2026
@sigtot sigtot force-pushed the raptor-on-board-access branch 2 times, most recently from 7b3c2ce to a5d1855 Compare January 28, 2026 13:27
@sigtot sigtot force-pushed the raptor-on-board-access branch from a5d1855 to 3d8648a Compare January 29, 2026 08:08
@t2gran t2gran added this to the 2.9 (next release) milestone Jan 29, 2026
@t2gran t2gran added the !New Feature A functional feature targeting the end user. label Jan 29, 2026
Comment on lines +30 to +36
void findOnBoardAccessForRound(int iterationDepartureTime);

/**
* Perform on-board (accesses on-board an already started trip) transit search for boardings and
* alight events for the current round.
*/
void findOnBoardAccessTransitForRound();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The names are a bit confusing, maybe we should make a follow up PR and try to improve some of the naming. The method names follow the naming conventions as existing methods so we should change all methods at the same time.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed to do this, along with rewording the other methods in this worker for consistency in a follow-up PR. A follow up PR is preferred to keep that refactor isolated and easy to review.

@sigtot sigtot requested a review from t2gran January 29, 2026 12:11
@sigtot sigtot marked this pull request as ready for review January 29, 2026 12:29
@sigtot sigtot requested a review from a team as a code owner January 29, 2026 12:29
@t2gran t2gran self-assigned this Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Entur On Entur Roadmap !New Feature A functional feature targeting the end user.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants