-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add checkstyle rules that we are already following #7244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev-2.x
Are you sure you want to change the base?
Add checkstyle rules that we are already following #7244
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #7244 +/- ##
=============================================
- Coverage 72.15% 72.14% -0.01%
- Complexity 21088 21090 +2
=============================================
Files 2297 2297
Lines 85223 85223
Branches 8487 8487
=============================================
- Hits 61490 61485 -5
- Misses 20753 20763 +10
+ Partials 2980 2975 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
t2gran
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the increase in the build time when adding this?
application/src/test/java/org/opentripplanner/framework/csv/parser/AbstractCsvParserTest.java
Show resolved
Hide resolved
…rser/AbstractCsvParserTest.java Co-authored-by: Thomas Gran <[email protected]>
There really isn't any (at least when you are not running openrewrite). |
Summary
Adds checkstyle rules that are possible to break (i.e. they are not handled by prettier) that we are not currently breaking. Therefore, this pr contains no code changes. This doesn't really slow down checkstyle processing.
Issue
Relates to #7068
Unit tests
Not needed
Documentation
No
Changelog
Skipped