Account for DST and multi-day trips in departure boards #7250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t2gran
added
!Bug
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #7250 +/- ##
=============================================
- Coverage 72.15% 72.12% -0.03%
Complexity 21089 21089
=============================================
Files 2297 2297
Lines 85218 85238 +20
Branches 8483 8489 +6
=============================================
- Hits 61487 61476 -11
- Misses 20753 20781 +28
- Partials 2978 2981 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
application/src/main/java/org/opentripplanner/transit/model/network/TripPattern.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| @ParameterizedTest | ||
| @CsvSource( |
Member
There was a problem hiding this comment.
Nice usage of CsvSource.
utils/src/main/java/org/opentripplanner/utils/time/ServiceDateUtils.java
Outdated
Show resolved
Hide resolved
utils/src/main/java/org/opentripplanner/utils/time/ServiceDateUtils.java
Outdated
Show resolved
Hide resolved
utils/src/main/java/org/opentripplanner/utils/time/ServiceDateUtils.java
Outdated
Show resolved
Hide resolved
utils/src/test/java/org/opentripplanner/utils/time/ServiceDateUtilsTest.java
Outdated
Show resolved
Hide resolved
leonardehrenfried
requested changes
Jan 29, 2026
Member
leonardehrenfried
left a comment
leonardehrenfried
left a comment
There was a problem hiding this comment.
This is an elegant solution this problem and ready to be merged, IMO, but please consider my typo fixes.
Co-authored-by: Leonard Ehrenfried <[email protected]>
t2gran
commented
Jan 29, 2026
Comment on lines
+158
to
+159
| /// - 29. March 2026 02:00 -> 03:00 First summer day start at 23:00, 1h overlap | ||
| /// - 25. October 2026 03:00 -> 02:00 Fist winter day start at 01:00, 1h gap |
Member
Author
There was a problem hiding this comment.
Suggested change
| /// - 29. March 2026 02:00 -> 03:00 First summer day start at 23:00, 1h overlap | |
| /// - 25. October 2026 03:00 -> 02:00 Fist winter day start at 01:00, 1h gap | |
| /// - 29. March 2026 02:00 -> 03:00 First summer service-day start at 23:00, 1h overlap | |
| /// - 25. October 2026 03:00 -> 02:00 Fist winter service-day start at 01:00, 1h gap |
sigtot
approved these changes
Jan 30, 2026
leonardehrenfried
approved these changes
Jan 30, 2026
Member
leonardehrenfried
left a comment
leonardehrenfried
left a comment
There was a problem hiding this comment.
There is one spelling mistake (fist -> first) but you can fix that on dev-2.x if you wish.
habrahamsson-skanetrafiken
requested changes
Jan 30, 2026
|
|
||
| // Adjust for overlapping service-days. This happens when we go from winter-time to summer time. | ||
| if (t1.getHour() == 23 && t1.plusHours(12).getHour() == 12) { | ||
| ld1 = ld1.plusDays(1); |
Contributor
There was a problem hiding this comment.
Don't you decrease ld0 in a corresponding way if any of the days from ld0 - 1 until t0 - 1 are 23 hour days?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When listing departures, some of the departures having a service date prior to the requested date is missing in the departure board listing.
The fix also account for DST. I have
Issue
Fixes #7249
Unit tests
✅ New unit tests are added to the complicated date calculation logic and to some of the business features methods.
Documentation
✅ Java doc is updated
Changelog
✅ This is relevant for the change log.
Bumping the serialization version id
✅ Bumping is necessary since the
TripPatternchanged.