Skip to content

Add tag mapper for Twin Cities#7713

Merged
leonardehrenfried merged 4 commits into
opentripplanner:dev-2.xfrom
ibi-group:skyways
Jun 22, 2026
Merged

Add tag mapper for Twin Cities#7713
leonardehrenfried merged 4 commits into
opentripplanner:dev-2.xfrom
ibi-group:skyways

Conversation

@leonardehrenfried

@leonardehrenfried leonardehrenfried commented Jun 15, 2026

Copy link
Copy Markdown
Member

Summary

It adds a new tag mapper specific for the new OTP deployment in the twin cities of Minneapolis and St. Paul, Minnesota.

There we want to exclude some special elevated tunnels from the street network.

Issue

No issue.

Unit tests

Added.

Documentation

Javadoc.

@leonardehrenfried leonardehrenfried added this to the 2.10 (next release) milestone Jun 15, 2026
@leonardehrenfried leonardehrenfried requested a review from a team as a code owner June 15, 2026 13:39
@leonardehrenfried leonardehrenfried added !New Feature A functional feature targeting the end user. +Skip Changelog This is not a relevant change for a product owner since last release. labels Jun 15, 2026
@codecov

codecov Bot commented Jun 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 74.05%. Comparing base (93ffc10) to head (d16bb49).

Files with missing lines Patch % Lines
...tripplanner/osm/tagmapping/OsmTagMapperSource.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #7713      +/-   ##
=============================================
- Coverage      74.05%   74.05%   -0.01%     
  Complexity     21870    21870              
=============================================
  Files           2426     2427       +1     
  Lines          85882    85892      +10     
  Branches        8553     8553              
=============================================
+ Hits           63603    63610       +7     
- Misses         19247    19249       +2     
- Partials        3032     3033       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work besides that one edge case that I don't think it has to be addressed right now.

public WayPropertySet buildWayPropertySet() {
var props = WayPropertySet.of();
props.setProperties(
new ExactMatchSpecifier(new Condition.Equals("name", "Minneapolis Skyway")),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this happen during the sidewalk naming phase? I think I can tweak that logic to take this into account, somehow.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I would like to do that in a separate PR.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect i happens during during sidewalk naming. Ofc tweak that in a separate PR.

@leonardehrenfried leonardehrenfried added this pull request to the merge queue Jun 22, 2026
Merged via the queue into opentripplanner:dev-2.x with commit 84920a1 Jun 22, 2026
8 checks passed
@leonardehrenfried leonardehrenfried deleted the skyways branch June 22, 2026 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

!New Feature A functional feature targeting the end user. +Skip Changelog This is not a relevant change for a product owner since last release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants