Add tag mapper for Twin Cities#7713
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #7713 +/- ##
=============================================
- Coverage 74.05% 74.05% -0.01%
Complexity 21870 21870
=============================================
Files 2426 2427 +1
Lines 85882 85892 +10
Branches 8553 8553
=============================================
+ Hits 63603 63610 +7
- Misses 19247 19249 +2
- Partials 3032 3033 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
2c707f0 to
5d7afab
Compare
5d7afab to
4285de9
Compare
029a070 to
53492cf
Compare
53492cf to
d16bb49
Compare
binh-dam-ibigroup
left a comment
There was a problem hiding this comment.
Seems to work besides that one edge case that I don't think it has to be addressed right now.
| public WayPropertySet buildWayPropertySet() { | ||
| var props = WayPropertySet.of(); | ||
| props.setProperties( | ||
| new ExactMatchSpecifier(new Condition.Equals("name", "Minneapolis Skyway")), |
There was a problem hiding this comment.
One interesting side effect is that although travel is banned on paths named "Minneapolis Skyway" or Saint Paul Skyway", some adjacent paths might be assigned the skyway name. I think this is happening for instance with http://localhost:9966/#/?fromPlace=Government%20Center%20Garage%2C%20Minneapolis%2C%20MN%2C%20USA%3A%3A44.97572686023062%2C-93.26494765593418&toPlace=701%20Nicollet%20Mall%2C%20Minneapolis%2C%20MN%2C%20USA%3A%3A44.97612336499955%2C-93.27201694444378&date=2026-06-16&time=17%3A58&arriveBy=false&mode=WALK%2CTRANSIT&modeButtons=transit&wheelchair=false&walkSpeed=1.34&bus=true&light_rail=true&ui_activeSearch=m4l2kagh3&ui_activeItinerary=0
There was a problem hiding this comment.
Does this happen during the sidewalk naming phase? I think I can tweak that logic to take this into account, somehow.
There was a problem hiding this comment.
But I would like to do that in a separate PR.
There was a problem hiding this comment.
I suspect i happens during during sidewalk naming. Ofc tweak that in a separate PR.
Summary
It adds a new tag mapper specific for the new OTP deployment in the twin cities of Minneapolis and St. Paul, Minnesota.
There we want to exclude some special elevated tunnels from the street network.
Issue
No issue.
Unit tests
Added.
Documentation
Javadoc.