Import experimental GTFS notices, add API#7726
Open
leonardehrenfried wants to merge 8 commits into
Open
Conversation
leonardehrenfried
added
the
!New Feature
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #7726 +/- ##
=============================================
+ Coverage 74.07% 74.10% +0.03%
- Complexity 21884 21955 +71
=============================================
Files 2426 2437 +11
Lines 85929 86191 +262
Branches 8563 8577 +14
=============================================
+ Hits 63651 63875 +224
- Misses 19246 19278 +32
- Partials 3032 3038 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
leonardehrenfried
force-pushed
the
notices
branch
from
9d3b1c8 to
2c16bf9
Compare
Add notices to API # Conflicts: # application/src/main/java/org/opentripplanner/apis/gtfs/generated/graphql-codegen.yml
leonardehrenfried
force-pushed
the
notices
branch
from
a0a5f5c to
866f5ef
Compare
optionsome
reviewed
Jun 22, 2026
Comment on lines
+119
to
+120
| createTripMapper(createRouteMapper()), | ||
| createRouteMapper() |
Member
There was a problem hiding this comment.
You are creating the route mapper twice.
optionsome
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This parses the GTFS spec proposal for notices into our internal data model. This internal model is used already by NeTEx and the GTFS equivalent is very similar. In fact the GTFS spec proposal is heavily influenced by NeTEx.
It also adds resolvers to the GTFS API. In order to give ourselves the opportunity to change the API I marked them as deprecated and added a warning.
Issue
google/transit#620
Unit tests
Lots added.
Documentation
Javadoc and schema docs.
Changelog
Yes.
Bumping the serialization version id
No serialized object changed, so no bump necessary.
cc @alec-georgoff @sebastianknopf