Skip to content

Small street module cleanup#7737

Merged
leonardehrenfried merged 5 commits into
opentripplanner:dev-2.xfrom
leonardehrenfried:small-street-cleanups
Jun 22, 2026
Merged

Small street module cleanup#7737
leonardehrenfried merged 5 commits into
opentripplanner:dev-2.xfrom
leonardehrenfried:small-street-cleanups

Conversation

@leonardehrenfried

Copy link
Copy Markdown
Member

Summary

This makes some small cleanups that I noticed after merging #7544.

  • renaming methods according to our conventions
  • make zone geometry required
  • fix a small typo in the debug UI

@leonardehrenfried leonardehrenfried added this to the 2.10 (next release) milestone Jun 18, 2026
@leonardehrenfried leonardehrenfried requested a review from a team as a code owner June 18, 2026 09:07
@leonardehrenfried leonardehrenfried added !Improvement A functional improvement or micro feature +Skip Changelog This is not a relevant change for a product owner since last release. labels Jun 18, 2026
@leonardehrenfried leonardehrenfried changed the title Small street module leanups Small street module cleanup Jun 18, 2026
@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.08%. Comparing base (c91572f) to head (5e85480).
⚠️ Report is 1 commits behind head on dev-2.x.

Files with missing lines Patch % Lines
...vector/geofencing/GeofencingZonesLayerBuilder.java 0.00% 5 Missing ⚠️
...opentripplanner/inspector/vector/LayerBuilder.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             dev-2.x    #7737   +/-   ##
==========================================
  Coverage      74.08%   74.08%           
- Complexity     21933    21937    +4     
==========================================
  Files           2434     2434           
  Lines          86131    86135    +4     
  Branches        8573     8573           
==========================================
+ Hits           63811    63815    +4     
- Misses         19278    19281    +3     
+ Partials        3042     3039    -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

testower
testower previously approved these changes Jun 18, 2026
@VillePihlava VillePihlava self-assigned this Jun 22, 2026
VillePihlava
VillePihlava previously approved these changes Jun 22, 2026
@leonardehrenfried leonardehrenfried added this pull request to the merge queue Jun 22, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 22, 2026
@leonardehrenfried leonardehrenfried dismissed stale reviews from VillePihlava and testower via 5e85480 June 22, 2026 10:05
@leonardehrenfried leonardehrenfried merged commit 88c3e78 into opentripplanner:dev-2.x Jun 22, 2026
9 checks passed
@leonardehrenfried leonardehrenfried deleted the small-street-cleanups branch June 22, 2026 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

!Improvement A functional improvement or micro feature +Skip Changelog This is not a relevant change for a product owner since last release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants