acceptableValidModeCombos configuration #1366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amy-corson-ibigroup
changed the title
binh-dam-ibigroup
approved these changes
Mar 18, 2025
lib/actions/apiV2.js
Outdated
Comment on lines
1130
to
1131
| modeCombo.every((m) => vc.includes(m)) && | ||
| vc.every((m) => modeCombo.includes(m)) |
There was a problem hiding this comment.
You can avoid one of the every by checking that the sizes of arrays are the same before hand.
There was a problem hiding this comment.
Thank you!
There was a problem hiding this comment.
Since I took this logic from core-utils, I used opentripplanner/otp-ui#819 as an opportunity to apply this feedback there too!
amy-corson-ibigroup
requested review from
daniel-heppner-ibigroup
and removed request for
josh-willis-arcadis
amy-corson-ibigroup
assigned daniel-heppner-ibigroup and unassigned josh-willis-arcadis
daniel-heppner-ibigroup
approved these changes
Mar 28, 2025
| return validModeCombinations.find( | ||
| (vc) => | ||
| modeCombo.length === vc.length && | ||
| vc.every((m) => modeCombo.includes(m)) |
There was a problem hiding this comment.
i wasn't sure but indeed this is the most efficient way to do this!
example-config.yml
Outdated
| ['WALK', 'TRANSIT', 'PERSONAL'], | ||
| ['WALK', 'TRANSIT', 'CAR'], | ||
| ['CAR'] | ||
| ] |
There was a problem hiding this comment.
indentation
daniel-heppner-ibigroup
assigned amy-corson-ibigroup and unassigned daniel-heppner-ibigroup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Creates a configurable list of acceptable mode combinations and filters itineraries to only return ones with mode combos that adhere to this list.
This should filter out itineraries with unwanted combinations such as "WALK" + "DRIVE"
PR Checklist: