Skip to content

[core] Fix Coverity issue in inference component of core #33702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mlukasze merged 7 commits into from
Jan 26, 2026
Merged

[core] Fix Coverity issue in inference component of core #33702

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e25535d
Remove not required copies in inference component
praasz Jan 20, 2026
cd29951
Remove use move on const ref parameter (moved state issue)
praasz Jan 20, 2026
4857281
Fix uninitialized members
praasz Jan 20, 2026
f163d12
Fix set supported ops names
praasz Jan 20, 2026
f60119c
Update copy rt info for cloned
praasz Jan 22, 2026
6925179
Merge branch 'master' into coverity/remove-not-required-copies-inference
praasz Jan 22, 2026
df0e833
Merge branch 'master' into coverity/remove-not-required-copies-inference
praasz Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/inference/dev_api/openvino/runtime/plugin_config.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ class OPENVINO_RUNTIME_API PluginConfig {

virtual void apply_model_specific_options(const IRemoteContext* context, const ov::Model& model) {}
void apply_env_options();
void apply_config_options(std::string_view device_name, std::filesystem::path config_path = "");
void apply_config_options(std::string_view device_name, const std::filesystem::path& config_path = {});
virtual void finalize_impl(const IRemoteContext* context) {}

template <typename T, PropertyMutability mutability>
Expand All @@ -227,7 +227,7 @@ class OPENVINO_RUNTIME_API PluginConfig {
}
}

ov::AnyMap read_config_file(std::filesystem::path filename, std::string_view target_device_name) const;
ov::AnyMap read_config_file(const std::filesystem::path& filename, std::string_view target_device_name) const;
ov::AnyMap read_env() const;
static ov::Any read_env(const std::string& option_name, std::string_view prefix, const ConfigOptionBase* option);
void cleanup_unsupported(ov::AnyMap& config) const;
Expand Down Expand Up @@ -272,7 +272,7 @@ struct ConfigOption : public TypedOption<T> {
std::string_view desc,
std::function<bool(T)> validator = nullptr)
: TypedOption<T>(default_val, prop_name, desc),
validator(validator) {
validator(std::move(validator)) {
OptionRegistrationHelper option(config, name, this);
}
constexpr static const auto visibility = visibility_;
Expand Down
4 changes: 2 additions & 2 deletions src/inference/src/dev/core_impl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ ov::SoPtr<ov::ICompiledModel> import_compiled_model(const ov::Plugin& plugin,
ov::SoPtr<ov::ICompiledModel> compiled_model;
if (auto blob_hint = config.find(ov::hint::compiled_blob.name()); blob_hint != config.end()) {
try {
auto compiled_blob = blob_hint->second.as<ov::Tensor>();
const auto& compiled_blob = blob_hint->second.as<ov::Tensor>();
compiled_model = context ? plugin.import_model(compiled_blob, context, config)
: plugin.import_model(compiled_blob, config);
} catch (...) {
Expand Down Expand Up @@ -1050,7 +1050,7 @@ std::vector<std::string> ov::CoreImpl::get_available_devices() const {
devices.push_back(device_name + '.' + deviceID);
}
} else if (!devicesIDs.empty()) {
devices.push_back(device_name);
devices.push_back(std::move(device_name));
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/inference/src/dev/device_id_parser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ std::vector<std::string> DeviceIDParser::get_hetero_devices(const std::string& f
}

if (!fallback_dev.empty())
deviceNames.push_back(fallback_dev);
deviceNames.push_back(std::move(fallback_dev));

return deviceNames;
}
Expand Down
4 changes: 1 addition & 3 deletions src/inference/src/dev/exec_model_info.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,7 @@ std::shared_ptr<ov::Node> ov::exec_model_info::ExecutionNode::clone_with_new_inp
auto cloned = std::make_shared<ExecutionNode>();

cloned->set_arguments(inputs);

for (auto kvp : get_rt_info())
cloned->get_rt_info()[kvp.first] = kvp.second;
cloned->get_rt_info().insert(get_rt_info().begin(), get_rt_info().end());

for (size_t i = 0; i < get_output_size(); ++i)
cloned->set_output_type(i, get_output_element_type(i), get_output_partial_shape(i));
Expand Down
8 changes: 6 additions & 2 deletions src/inference/src/dev/iplugin.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,11 @@ bool is_graph_input_node(const std::shared_ptr<ov::Node>& node) {

} // namespace

ov::IPlugin::IPlugin() : m_executor_manager(ov::threading::executor_manager()) {}
ov::IPlugin::IPlugin()
: m_plugin_name(),
m_core(),
m_executor_manager(ov::threading::executor_manager()),
m_version() {}
Comment on lines +43 to +47
Copy link
Contributor

@t-jankowski t-jankowski Jan 23, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does coverity complain here? These three members are default initialized anyway?

Copy link
Contributor Author

@praasz praasz Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The m_version members are not initialized. Added explicit all members.


void ov::IPlugin::set_version(const ov::Version& version) {
m_version = version;
Expand Down Expand Up @@ -479,7 +483,7 @@ std::unordered_set<std::string> ov::get_supported_nodes(
// and operation names from original model
for (auto&& name : supported) {
if (original_ops.count(name)) {
res.insert(name);
res.insert(std::move(name));
}
}
// Remove parameters (or parameter/constant + convert) which has no supported consumers
Expand Down
7 changes: 4 additions & 3 deletions src/inference/src/dev/plugin_config.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ void PluginConfig::apply_env_options() {
set_property(env_properties);
}

void PluginConfig::apply_config_options(std::string_view device_name, std::filesystem::path config_path) {
void PluginConfig::apply_config_options(std::string_view device_name, const std::filesystem::path& config_path) {
if (!config_path.empty()) {
ov::AnyMap config_properties = read_config_file(config_path, device_name);
cleanup_unsupported(config_properties);
Expand All @@ -156,7 +156,8 @@ void PluginConfig::apply_config_options(std::string_view device_name, std::files
}
}

ov::AnyMap PluginConfig::read_config_file(std::filesystem::path filename, std::string_view target_device_name) const {
ov::AnyMap PluginConfig::read_config_file(const std::filesystem::path& filename,
std::string_view target_device_name) const {
if (filename.empty())
return {};

Expand Down Expand Up @@ -208,7 +209,7 @@ ov::AnyMap PluginConfig::read_env() const {

for (auto& [name, option] : m_options_map) {
if (auto val = read_env(name, m_allowed_env_prefix, option); !val.empty()) {
config[name] = val;
config[name] = std::move(val);
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/inference/src/dev/threading/cpu_streams_executor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,7 @@ struct CPUStreamsExecutor::Impl {
#if OV_THREAD == OV_THREAD_TBB || OV_THREAD == OV_THREAD_TBB_AUTO || OV_THREAD == OV_THREAD_TBB_ADAPTIVE
auto& arena = stream._taskArena;
if (nullptr != arena) {
arena->execute(std::move(task));
arena->execute(task);
} else {
task();
}
Expand Down
Loading