[DREAM-802] Migrate phase definitions and export template lists to BorderBoxList - #24644
Merged
Merged
Conversation
This was referenced Aug 6, 2026
myabc
force-pushed
the
implementation/DREAM-802-admin-list-migrations
branch
from
August 6, 2026 19:43
989ca36 to
b274756
Compare
myabc
commented
Aug 6, 2026
Comment on lines
+134
to
+139
| # Cuprite does not reliably trigger Dragula's mouse lifecycle for Primer lists, | ||
| # so exercise the generic controller's drop callback once it is connected. | ||
| # This is a synthetic, controller-level drop: it bypasses the drag handle, | ||
| # canStartDrag, and Dragula's pointer lifecycle, proving persistence but not | ||
| # the user interaction. Real drag coverage arrives with the Selenium | ||
| # sortable-lists specs when these surfaces migrate under DREAM-789. |
myabc
force-pushed
the
implementation/DREAM-802-admin-list-migrations
branch
from
August 6, 2026 20:44
b274756 to
8ba717b
Compare
myabc
marked this pull request as ready for review
August 6, 2026 21:16
myabc
force-pushed
the
implementation/DREAM-802-admin-list-migrations
branch
from
August 6, 2026 21:38
8ba717b to
defada7
Compare
myabc
force-pushed
the
implementation/DREAM-802-admin-list-migrations
branch
from
August 7, 2026 07:17
defada7 to
ad49f9d
Compare
myabc
force-pushed
the
implementation/DREAM-802-admin-list-migrations
branch
from
August 7, 2026 07:39
ad49f9d to
8c97b3e
Compare
|
Warning Flaky specs
🤖 Ask Copilot to investigateCopy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer. |
myabc
force-pushed
the
implementation/DREAM-802-admin-list-migrations
branch
from
August 7, 2026 19:07
8c97b3e to
4d17a93
Compare
myabc
force-pushed
the
implementation/DREAM-802-admin-list-migrations
branch
2 times, most recently
from
August 12, 2026 09:39
ef1a343 to
e8d2883
Compare
myabc
force-pushed
the
implementation/DREAM-802-admin-list-migrations
branch
2 times, most recently
from
August 12, 2026 11:04
0c2fa2e to
d57abda
Compare
Base automatically changed from
implementation/DREAM-801-borderbox-header-api
to
dev
August 12, 2026 12:25
Moves phase-definition rows to the shared list and preserves drag ids. https://community.openproject.org/wp/DREAM-697
Ports the export-template selector and its accessible toggles. https://community.openproject.org/wp/DREAM-697
Filtering the phase definitions to no matches left a bare header box with a detached plain-text notice below it. The list's own empty state now appears inside the box through the dynamic lifecycle. https://community.openproject.org/wp/DREAM-802
myabc
force-pushed
the
implementation/DREAM-802-admin-list-migrations
branch
from
August 12, 2026 12:26
d57abda to
c3c98e0
Compare
|
Warning Flaky specs
🤖 Ask Copilot to investigateCopy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/wp/DREAM-802
What are you trying to accomplish?
Second slice of the DREAM-697 split: migrates the two admin surfaces whose markup gates DREAM-789, so the sortable-lists migration sequence under DREAM-671 can proceed once this lands.
Settings::ProjectPhaseDefinitions::IndexComponentmoves fromborder_box_containertoOpenProject::Common::BorderBoxListComponent.WorkPackageTypes::ExportTemplateListComponentdoes the same, keeping its readonly Enterprise banner state and per-row toggles.empty_state_behavior: :dynamic: filtering to no matches now shows the blankslate inside the box, replacing the detached plain-text "No items found" notice.What approach did you choose and why?
One commit per surface with component specs each, mirroring the review structure of the rest of the stack. Stacked on the DREAM-801 API PR (#24643) because both surfaces use the reworked menu and header slots.
Visual comparisons
Show baseline/candidate screenshots
Baseline is shown on the left; the candidate stack is shown on the right. (Screenshots predate the empty-state rework; regeneration pending.)
Project phase definitions
Work package type PDF export templates
Merge checklist