Skip to content

[67494] Replace Angular loading spinner with Primer loadind spinner in Feedback Dialogs - #355

Merged
HDinger merged 1 commit into
mainfrom
code-maintenance/67494-replace-angular-loading-spinner-with-primer-loadind-spinner-in-feedback-dialogs
Sep 17, 2025
Merged

[67494] Replace Angular loading spinner with Primer loadind spinner in Feedback Dialogs#355
HDinger merged 1 commit into
mainfrom
code-maintenance/67494-replace-angular-loading-spinner-with-primer-loadind-spinner-in-feedback-dialogs

Conversation

@HDinger

@HDinger HDinger commented Sep 17, 2025

Copy link
Copy Markdown
Collaborator

What are you trying to accomplish?

Remove the custom spinner for FeedbackMessage and use the default one from the Blankslate

Screenshots

Bildschirmfoto 2025-09-17 um 11 02 32 Bildschirmfoto 2025-09-17 um 11 02 46

Integration

No changes needed

List the issues that this change affects.

https://community.openproject.org/wp/67494

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.

@changeset-bot

changeset-bot Bot commented Sep 17, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: eaf9354

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@openproject/primer-view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@HDinger
HDinger force-pushed the code-maintenance/67494-replace-angular-loading-spinner-with-primer-loadind-spinner-in-feedback-dialogs branch from 2b6f8d6 to eaf9354 Compare September 17, 2025 09:17
@bsatarnejad
bsatarnejad self-requested a review September 17, 2025 09:28

@bsatarnejad bsatarnejad left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@HDinger
HDinger merged commit 6c9ae38 into main Sep 17, 2025
29 checks passed
@HDinger
HDinger deleted the code-maintenance/67494-replace-angular-loading-spinner-with-primer-loadind-spinner-in-feedback-dialogs branch September 17, 2025 09:39
@openprojectci openprojectci mentioned this pull request Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants