net/upnp: Complete service improvements

[Self-Hosting-Group]

No description provided.

[Self-Hosting-Group]

See 26.1 coming soon. Can we continue here?

[Self-Hosting-Group]

If I just copy the syslog filter template, it will not be applied; a /etc/rc.d/syslogd restart is necessary.

[fichtner]

syslog is always restarted post-install for plugins:

https://github.com/opnsense/core/blob/5da971f2c678fa6d01fb2db4b8a190fd41b8c70a/src/etc/rc.configure_plugins#L46-L49

See 26.1 coming soon. Can we continue here?

Sure, the PR is still in draft mode... you need to signal when you're ready first.

[fichtner]

I prefer not to comment out large blocks with /* */

Suggested change

	/* Disable to workaround daemon bug with PCP/NAT-PMP epoch on BSD
	if (!empty($upnp_config['sysuptime'])) {
	$config_text .= "system_uptime=yes\n";
	}
	} */
	if (!empty($upnp_config['sysuptime'])) {
	/* XXX disable to workaround daemon bug with PCP/NAT-PMP epoch on BSD */
	//$config_text .= "system_uptime=yes\n";
	}

[fichtner]

Suggested change

	PLUGIN_VERSION= 1.8
	PLUGIN_REVISION= 1
	PLUGIN_VERSION= 1.9

Since you're adding syslog definition it would be clearer to make a new version

[fichtner]

yes please, I did forget these

[fichtner]

what about these? and can you bring it out of draft mode please?

[Self-Hosting-Group]

I'll add that. Otherwise, there are no further changes here.

[Self-Hosting-Group]

Removed the draft. Will create the ports PR.

[Self-Hosting-Group]

Sorry for the delay. I've just pushed the changes. Since the OPNsense 26.1 release is tomorrow and this PR is ready, it would be great if you could give me a quick comment on the following points. I'll then prepare the missing changelog and remove the draft flag from the PR to be merged.

Sure, the PR is still in draft mode... you need to signal when you're ready first.

I did this so that the PR wouldn't be merged unexpectedly too early. Thank you for the review.

syslog is always restarted post-install for plugins:

https://github.com/opnsense/core/blob/5da971f2c678fa6d01fb2db4b8a190fd41b8c70a/src/etc/rc.configure_plugins#L46-L49

1. OK. My question was incomplete. I noticed that copying the snippet and restarting the syslogd logs daemon errors, but not after restarting the router. Does this work with a normal plugin installation? I didn't compile the package this time.

2. Daemon errors are now logged, but messages with higher syslog severity (e.g. info with miniupnpd -v) seem to be filtered out, even if enabled in the UI. Is there anything that can be done?

[fichtner]

OK. My question was incomplete. I noticed that copying the snippet and restarting the syslogd logs daemon errors, but not after restarting the router. Does this work with a normal plugin installation? I didn't compile the package this time.

Yep should be good as is.

Daemon errors are now logged, but messages with higher syslog severity (e.g. info with miniupnpd -v) seem to be filtered out, even if enabled in the UI. Is there anything that can be done?

Where are you logging to? System log? It may be better to add a separate log file and page for miniupnpd alone. The system log is capped to notice (so won't see info or debug) for historic reasons.

[Self-Hosting-Group]

It may be better to add a separate log file and page for miniupnpd alone.

Separate log file implemented. Please review.

[Self-Hosting-Group]

PS: The last update changed the headings Source IP/port to Remote IP/port, and a ports patch to improve daemon logging will be available today.

[Self-Hosting-Group]

@fichtner @fraenki Critical issue detected in OPNsense 26.1 and registerAnchor function used in plugin.

pfctl_get_rules_info: Invalid argument is logged. registerAnchor function used in miniupnpd.inc does not seem to be working.

/sbin/pfctl -P -a miniupnpd -s nat
pfctl: DIOCGETRULES: Invalid argument

See: https://forum.opnsense.org/index.php?msg=258237

[Self-Hosting-Group]

Let us release this PR in a .2 version after the core has been corrected in a new version.

[Self-Hosting-Group]

@fichtner I also did a fresh installation of 26.1, including 26.1_4, to rule out errors during migration. But even then, the necessary anchors are not created.

[fichtner]

Thanks for the hint. I found it https://forum.opnsense.org/index.php?topic=50520.msg258554#msg258554

[Self-Hosting-Group]

Thank you for fixing it so quickly! I've checked the patch and it's working.

[Self-Hosting-Group]

A 26.1_5 release?

[fichtner]

This should have been in today’s hotfix, but there likely won’t be another. We’re targeting a 26.1.1 next week for a lot of other reasons. Not sure how early or late in the week that will be.