Adapt docker recipes to Python 3.11 #292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@not522 Could you review this PR? |
not522
reviewed
Nov 1, 2024
kubernetes/mlflow/Dockerfile
Outdated
| @@ -1,13 +1,11 @@ | |||
| # NOTE(crcrpar): optuna/optuna:py3.7-dev can be used as base instead. | |||
| FROM python:3.7-slim-buster | |||
| FROM python:3.11-slim-buster | |||
Member
There was a problem hiding this comment.
buster means that this image uses Debian 10. It has been EOL https://www.debian.org/releases/index.en.html, so I think a newer version is preferred. How about python:3.11-slim?
Contributor
Author
There was a problem hiding this comment.
Sorry for the late response, but I applied your suggestion!
|
This pull request has not seen any recent activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As we dropped Python 3.7, I updated the docker image recipes to Python 3.11.
Description of the changes