Skip to content

Adapt docker recipes to Python 3.11 #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Adapt docker recipes to Python 3.11 #292

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f9e6a4
Adapt docker recipes to Python 3.11
nabenabe0928 Oct 30, 2024
e178311
Apply mizuno's suggestion
nabenabe0928 Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,11 +181,11 @@ Our Docker images for most examples are available with the tag ending with `-dev
For example, [PyTorch Simple](./pytorch/pytorch_simple.py) can be run via:

```bash
$ docker run --rm -v $(pwd):/prj -w /prj optuna/optuna:py3.7-dev python pytorch/pytorch_simple.py
$ docker run --rm -v $(pwd):/prj -w /prj optuna/optuna:py3.11-dev python pytorch/pytorch_simple.py
```

Additionally, our visualization example can also be run on Jupyter Notebook by opening `localhost:8888` in your browser after executing the following:

```bash
$ docker run -p 8888:8888 --rm optuna/optuna:py3.7-dev jupyter notebook --allow-root --no-browser --port 8888 --ip 0.0.0.0 --NotebookApp.token='' --NotebookApp.password=''
$ docker run -p 8888:8888 --rm optuna/optuna:py3.11-dev jupyter notebook --allow-root --no-browser --port 8888 --ip 0.0.0.0 --NotebookApp.token='' --NotebookApp.password=''
```
8 changes: 3 additions & 5 deletions kubernetes/mlflow/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
# NOTE(crcrpar): optuna/optuna:py3.7-dev can be used as base instead.
FROM python:3.7-slim-buster
FROM python:3.11-slim-buster
Copy link
Member

@not522 not522 Nov 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

buster means that this image uses Debian 10. It has been EOL https://www.debian.org/releases/index.en.html, so I think a newer version is preferred. How about python:3.11-slim?

Copy link
Contributor Author

@nabenabe0928 nabenabe0928 Nov 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late response, but I applied your suggestion!


WORKDIR /usr/src/

RUN pip install --no-cache-dir optuna psycopg2-binary mlflow \
&& pip install --no-cache-dir \
torch==1.10.0+cpu \
torchvision==0.11.1+cpu \
-f https://download.pytorch.org/whl/torch_stable.html \
&& pip install --no-cache-dir torch torchvision \
--index-url https://download.pytorch.org/whl/cpu \
&& pip install pytorch-lightning

COPY pytorch_lightning_distributed.py .
Expand Down
2 changes: 1 addition & 1 deletion kubernetes/simple/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM python:3.7-slim-buster
FROM python:3.11-slim-buster

WORKDIR /usr/src/

Expand Down
Loading