Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add constructor for Dicyclic groups and alias for Quaternion groups #4661

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Merge branch 'master' into jn/dicyclic

05ac3ec
Select commit
Loading
Failed to load commit list.
Open

Add constructor for Dicyclic groups and alias for Quaternion groups #4661

Merge branch 'master' into jn/dicyclic
05ac3ec
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 12, 2025 in 1s

84.38% (-0.01%) compared to 4bccbc1, passed because coverage increased by 0% when compared to adjusted base (84.38%)

View this Pull Request on Codecov

84.38% (-0.01%) compared to 4bccbc1, passed because coverage increased by 0% when compared to adjusted base (84.38%)

Details

Codecov Report

Attention: Patch coverage is 90.19608% with 5 lines in your changes missing coverage. Please review.

Project coverage is 84.38%. Comparing base (4bccbc1) to head (05ac3ec).

Files with missing lines Patch % Lines
src/Groups/group_constructors.jl 90.19% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4661      +/-   ##
==========================================
- Coverage   84.38%   84.38%   -0.01%     
==========================================
  Files         673      673              
  Lines       90284    90287       +3     
==========================================
+ Hits        76185    76186       +1     
- Misses      14099    14101       +2     
Files with missing lines Coverage Δ
src/Groups/group_constructors.jl 93.49% <90.19%> (+0.11%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.