New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add constructor for Dicyclic groups and alias for Quaternion groups #4661

Open

jamesnohilly wants to merge 11 commits into oscar-system:master from jamesnohilly:jn/dicyclic

Open

Add constructor for Dicyclic groups and alias for Quaternion groups #4661

Merge branch 'master' into jn/dicyclic

Codecov / codecov/patch succeeded Mar 12, 2025 in 0s

90.19% of diff hit (target 84.38%)

View this Pull Request on Codecov

90.19% of diff hit (target 84.38%)

Annotations

Check warning on line 453 in src/Groups/group_constructors.jl

codecov / codecov/patch

src/Groups/group_constructors.jl#L453

Added line #L453 was not covered by tests

Check warning on line 486 in src/Groups/group_constructors.jl

codecov / codecov/patch

src/Groups/group_constructors.jl#L486

Added line #L486 was not covered by tests

Check warning on line 519 in src/Groups/group_constructors.jl

codecov / codecov/patch

src/Groups/group_constructors.jl#L519

Added line #L519 was not covered by tests

Check warning on line 621 in src/Groups/group_constructors.jl

codecov / codecov/patch

src/Groups/group_constructors.jl#L621

Added line #L621 was not covered by tests

Check warning on line 724 in src/Groups/group_constructors.jl

codecov / codecov/patch

src/Groups/group_constructors.jl#L724

Added line #L724 was not covered by tests

View more details on Codecov