Skip to content

fix: bump Hecke version #4788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Compat = "4.13.0"
Distributed = "1.6"
GAP = "0.13.1"
GAP_lib_jll = "~400.1400.4" # remove again once GAP.jl requires this version
Hecke = "= 0.35.15"
Hecke = "0.35.17"
JSON = "^0.20, ^0.21"
JSON3 = "1.13.2"
LazyArtifacts = "1.6"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ end
function all_exponents(W::MPolyDecRing, d::FinGenAbGroupElem)
D = W.D
is_free(D) || error("Grading group must be free")
h = hom(free_abelian_group(ngens(W)), W.d)
h = hom(free_abelian_group(ngens(W)), D, W.d)
fl, p = has_preimage_with_preimage(h, d)
R = base_ring(W)
B = Vector{Int}[]
Expand Down
4 changes: 2 additions & 2 deletions experimental/QuadFormAndIsom/src/embeddings.jl
Original file line number Diff line number Diff line change
Expand Up @@ -27,15 +27,15 @@ function _sum_with_embeddings_orthogonal_groups(A::TorQuadModule, B::TorQuadModu
geneOAinOD = elem_type(OD)[]
for f in gens(OA)
imgf = data.(union!(AinD.(f.(gens(A))), gensDB))
fab = hom(gene, imgf)
fab = hom(abelian_group(D), abelian_group(D), gene, imgf)
fD = OD(hom(D, D, matrix(fab)); check=false)
push!(geneOAinOD, fD)
end

geneOBinOD = elem_type(OD)[]
for f in gens(OB)
imgf = data.(union(gensDA, BinD.(f.(gens(B)))))
fab = hom(gene, imgf)
fab = hom(abelian_group(D), abelian_group(D), gene, imgf)
fD = OD(hom(D, D, matrix(fab)); check=false)
push!(geneOBinOD, fD)
end
Expand Down
2 changes: 1 addition & 1 deletion src/Groups/abelian_aut.jl
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ function embedding_orthogonal_group(i::TorQuadModuleMap)
geneOAinOD = elem_type(OD)[]
for f in gens(OA)
imgf = data.(union(i.(f.(gens(A))), j.(gens(B))))
fab = hom(gene, imgf)
fab = hom(abelian_group(D), abelian_group(D), gene, imgf)
fD = OD(hom(D, D, fab.map))
push!(geneOAinOD, fD)
end
Expand Down
4 changes: 2 additions & 2 deletions src/Groups/homomorphisms.jl
Original file line number Diff line number Diff line change
Expand Up @@ -153,9 +153,9 @@ function hom(G::GAPGroup, A::FinGenAbGroup, gensG::Vector, imgs::Vector{FinGenAb

# map B to A as prescribed
if length(gensG) == 0
map2 = hom([zero(B)], [zero(A)], check = check)
map2 = hom(B, A, [zero(B)], [zero(A)], check = check)
else
map2 = hom([iso(map1(x)) for x in gensG], imgs, check = check)
map2 = hom(B, A, [iso(map1(x)) for x in gensG], imgs, check = check)
end

# create the composition
Expand Down
2 changes: 1 addition & 1 deletion src/Groups/matrices/iso_nf_fq.jl
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ function test_modulus(matrices::Vector{T}, p::Int) where T <: MatrixElem{AbsSimp
if p == 2
return false, GF(p, cached = false), matrices_Fq, Hecke.NfOrdToFqMor()
end
O = EquationOrder(K)
O = equation_order(K)
if mod(discriminant(O), p) == 0
return false, GF(p, cached = false), matrices_Fq, Hecke.NfOrdToFqMor()
end
Expand Down
4 changes: 2 additions & 2 deletions src/Rings/NumberField.jl
Original file line number Diff line number Diff line change
Expand Up @@ -739,12 +739,12 @@ function Hecke.any_order(K::NfNSGen)
@assert isone(denominator(b.f))
end

O = Order(K, B)
O = order(K, B)

return O
end

function Hecke.MaximalOrder(K::NfNSGen)
function Hecke.maximal_order(K::NfNSGen)
E = any_order(K)
return Hecke._maximal_order_round_four(E)
end
Expand Down
2 changes: 1 addition & 1 deletion src/Rings/mpoly-graded.jl
Original file line number Diff line number Diff line change
Expand Up @@ -1430,7 +1430,7 @@ function monomial_basis(W::MPolyDecRing, d::FinGenAbGroupElem)
@req coefficient_ring(W) isa AbstractAlgebra.Field "The coefficient ring must be a field"
D = W.D
is_free(D) || error("Grading group must be free")
h = hom(free_abelian_group(ngens(W)), W.d)
h = hom(free_abelian_group(ngens(W)), D, W.d)
fl, p = has_preimage_with_preimage(h, d)
R = base_ring(W)
B = elem_type(W)[]
Expand Down
2 changes: 1 addition & 1 deletion test/NumberTheory/nmbthy.jl
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ end
k, a = wildanger_field(3, 13)
zk = maximal_order(k)
b = zk(8*a^2 - 24*a - 1)
o = Order(k, 8 .* basis(zk))
o = order(k, 8 .* basis(zk))
@test length(norm_equation(zk, norm(b))) == 4
@test length(norm_equation(o, norm(b))) == 3

Expand Down
Loading