Skip to content

fix: bump Hecke version #4788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2025
Merged

fix: bump Hecke version #4788

merged 1 commit into from
Apr 5, 2025

Conversation

thofma
Copy link
Collaborator

@thofma thofma commented Apr 4, 2025

  • purge Hecke.Order, Hecke.EquationOrder and Hecke.MaximalOrder

@thofma thofma force-pushed the th/ooorder branch 5 times, most recently from 0fad74a to dff4264 Compare April 4, 2025 20:37
@thofma
fix: bump Hecke version
48b397f 
- purge Hecke.Order, Hecke.EquationOrder and Hecke.MaximalOrder
@thofma
Copy link
Collaborator Author

thofma commented Apr 5, 2025

@StevellM the hom things are also fixed here

@thofma thofma requested a review from Copilot April 5, 2025 06:57
Copilot
Copilot AI reviewed Apr 5, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 9 changed files in this pull request and generated no comments.

Files not reviewed (8)
  • experimental/DoubleAndHyperComplexes/src/Morphisms/strand_functionality.jl: Language not supported
  • experimental/QuadFormAndIsom/src/embeddings.jl: Language not supported
  • src/Groups/abelian_aut.jl: Language not supported
  • src/Groups/homomorphisms.jl: Language not supported
  • src/Groups/matrices/iso_nf_fq.jl: Language not supported
  • src/Rings/NumberField.jl: Language not supported
  • src/Rings/mpoly-graded.jl: Language not supported
  • test/NumberTheory/nmbthy.jl: Language not supported

@thofma thofma requested a review from StevellM April 5, 2025 08:08
StevellM
StevellM approved these changes Apr 5, 2025
View reviewed changes
Copy link
Member

@StevellM StevellM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@thofma thofma merged commit c2562fc into master Apr 5, 2025
33 checks passed
@thofma thofma deleted the th/ooorder branch April 5, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@StevellM StevellM StevellM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thofma @StevellM