Skip to content

Included tests for internal/collector/source #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
nathannaveen wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Included tests for internal/collector/source #310

nathannaveen wants to merge 3 commits into from

Conversation

@nathannaveen
Copy link
Contributor

@nathannaveen nathannaveen commented Jan 16, 2023

  • Included some tests for internal/collector/source

Signed-off-by: nathannaveen [email protected]

@nathannaveen
Copy link
Contributor Author

nathannaveen commented Jan 16, 2023

I couldn't complete the Get() tests because when mocking bqAPI it resulted in the files calling each other in a cycle. I also didn't complete the NewSource() tests because I can't mock bigquery.NewClient().

@nathannaveen
Included tests for internal/collector/source
f853a9c 
- Included some tests for internal/collector/source

Signed-off-by: nathannaveen <[email protected]>
@nathannaveen nathannaveen force-pushed the nathan/feat/collector/depsdev/sourceTests branch from b40e003 to f853a9c Compare January 16, 2023 22:42
@nathannaveen nathannaveen mentioned this pull request Jan 20, 2023
Open
@nathannaveen
Copy link
Contributor Author

nathannaveen commented Feb 24, 2023

@calebbrown A friendly ping!

calebbrown
calebbrown requested changes Feb 27, 2023
View reviewed changes
@nathannaveen nathannaveen requested a review from calebbrown March 2, 2023 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@calebbrown calebbrown Awaiting requested review from calebbrown

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nathannaveen @calebbrown