Skip to content

PointCloud mask#460

Merged
Samahu merged 9 commits into
masterfrom
apply-mask-to-lidarscan
May 29, 2025
Merged

PointCloud mask#460
Samahu merged 9 commits into
masterfrom
apply-mask-to-lidarscan

Conversation

@Samahu

@Samahu Samahu commented May 28, 2025

Copy link
Copy Markdown
Contributor

Related Issues & PRs

  • None

Summary of Changes

  • Implemented a mask filter on the received LidarScan.
  • The mask is applied to the cloud + the image messages
  • If the supplied mask size is different from the received LidarScan, the driver will resize the mask to match incoming scans size.

Validation

  • Test out a sequence without applying a mask:
    image
  • Generate any mask composed of Black/White pixels, such as:
    image
  • Apply the mask as follows:
roslaunch ouster_ros driver.launch sensor_hostname:=<source_url> mask_path:=<path/to/mask.png>
  • Observe the masked image in RVIZ/image_view:
    image
  • Observe the mask cloud in RVIZ/cloud_view
    image

@Samahu Samahu self-assigned this May 28, 2025
@Samahu Samahu added the enhancement New feature or request label May 28, 2025
@Samahu Samahu requested a review from Copilot May 28, 2025 16:59
@Samahu Samahu marked this pull request as ready for review May 28, 2025 17:16

This comment was marked as resolved.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Comment thread src/point_cloud_processor.h Outdated
@Samahu Samahu changed the title Quick prototype of the pointcloud mask PointCloud mask May 29, 2025
@Samahu Samahu marked this pull request as draft May 29, 2025 16:34

@matthew-lidar matthew-lidar left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, though I would at least change how we handle input mask pixel values.

Comment thread src/point_cloud_processor_factory.h
Comment thread src/image_processor.h Outdated
Comment thread src/point_cloud_processor.h Outdated
@Samahu Samahu requested a review from matthew-lidar May 29, 2025 17:53
@Samahu Samahu marked this pull request as ready for review May 29, 2025 17:53
@Samahu Samahu merged commit b85d8ee into master May 29, 2025
3 of 6 checks passed
@Samahu Samahu deleted the apply-mask-to-lidarscan branch May 29, 2025 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants