Add --http-addr option to sensor_replay plugin.

[sleitch-ouster]

Related Issues & PRs

I am trying to use sensor_replay to create a virtual sensor to use with Ouster Detect.

I'm using the "add sensor by hostname" function to add the virtual sensor, which calls out the http address to validate that the sensor exists. I need this functionality to allow the sensor to be on another machine.

Summary of Changes

Add --http-addr option to the source_replay plugin and plumb it through to the server.

Validation

ouster-cli source -s replay.osf sensor_replay --loop true --udp-dest ouster-detect --http-addr 0.0.0.0

Verify that the detect instance can add the sensor.

[matthew-lidar]

Should we change the default address to 0.0.0.0?

[sleitch-ouster]

My immediate reaction is to keep it local for security reasons and make open access opt-in.

That being said, the entire command is very opt-in, so maybe it's not so harmful.

[Samahu]

My immediate reaction is to keep it local for security reasons and make open access opt-in.

That being said, the entire command is very opt-in, so maybe it's not so harmful.

Yeah, since this is mainly a development aid feature I would also keep localhost as the default. (it fits my main usage case).
With your change people can adjust it as they like.