Implements Node.js behaviour for parallel/test-tls-set-ciphers-error.js #19443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Updated 7:04 PM PT - May 20th, 2025
❌ @alii, your commit b2cc0d5 has 3 failures in
🧪 To try this PR locally: bunx bun-pr 19443That installs a local version of the PR into your bun-19443 --bun |
alii
changed the title
alii
requested review from
a team,
heimskr and
nektro
and removed request for
a team
alii
commented
May 2, 2025
cirospaciari
previously approved these changes
May 7, 2025
190n
reviewed
May 7, 2025
heimskr
reviewed
May 7, 2025
heimskr
suggested changes
May 7, 2025
nektro
reviewed
May 7, 2025
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
190n
suggested changes
May 19, 2025
Contributor
190n
left a comment
190n
left a comment
There was a problem hiding this comment.
comment + fix the linter issue
…un into ali/test-tls-set-ciphers-error
190n
reviewed
May 19, 2025
Contributor
190n
left a comment
190n
left a comment
There was a problem hiding this comment.
fix the lint, it says DEFAULT_CIPHERS_SET is unused in tls.ts
190n
previously approved these changes
May 19, 2025
190n
previously approved these changes
May 19, 2025
heimskr
previously approved these changes
May 20, 2025
heimskr
approved these changes
May 21, 2025
190n
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
How did you verify your code works?
The test passes