Implements Node.js behaviour for parallel/test-tls-set-ciphers-error.js

src/js/node/tls.ts

@@ -252,7 +252,7 @@ function SecureContext(options) {
 }
 
 function createSecureContext(options) {
-  return new SecureContext(options);
+  return SecureContext(options);
 }
 
 // Translate some fields from the handle's C-friendly format into more idiomatic
@@ -562,6 +562,18 @@ function Server(options, secureConnectionListener): void {
       if (typeof rejectUnauthorized !== "undefined") {
         this._rejectUnauthorized = rejectUnauthorized;
       } else this._rejectUnauthorized = rejectUnauthorizedDefault;
+
+      if (typeof options.ciphers !== "undefined") {
+        if (typeof options.ciphers !== "string") {
+          throw $ERR_INVALID_ARG_TYPE("options.ciphers", "string", options.ciphers);
+        }
+        const supported = getCiphers();
+        const requested = options.ciphers.split(":");
+        const foundMatch = requested.some(r => supported.some(s => s.toLowerCase() === r.toLowerCase()));
+        if (!foundMatch) {
+          throw new Error("no cipher match");
+        }
+      }
     }
   };
 

test/js/node/test/parallel/test-tls-set-ciphers-error.js

@@ -0,0 +1,25 @@
+'use strict';
+const common = require('../common');
+
+if (!common.hasCrypto)
+  common.skip('missing crypto');
+
+const assert = require('assert');
+const tls = require('tls');
+const fixtures = require('../common/fixtures');
+
+{
+  const options = {
+    key: fixtures.readKey('agent2-key.pem'),
+    cert: fixtures.readKey('agent2-cert.pem'),
+    ciphers: 'aes256-sha'
+  };
+  assert.throws(() => tls.createServer(options, common.mustNotCall()),
+                /no[_ ]cipher[_ ]match/i);
+  options.ciphers = 'FOOBARBAZ';
+  assert.throws(() => tls.createServer(options, common.mustNotCall()),
+                /no[_ ]cipher[_ ]match/i);
+  options.ciphers = 'TLS_not_a_cipher';
+  assert.throws(() => tls.createServer(options, common.mustNotCall()),
+                /no[_ ]cipher[_ ]match/i);
+}