feat: Indigo theme updates for frontend-base#220
Merged
Conversation
Faraz32123
reviewed
May 11, 2026
Collaborator
|
Can we also check footer links placement.
|
Collaborator
|
@arbirali can we change the base branch to main for this PR. |
ahmed-arb
self-requested a review
May 12, 2026 09:12
ahmed-arb
approved these changes
May 13, 2026
ahmed-arb
left a comment
ahmed-arb
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Please add a changelog entry.
Faraz32123
approved these changes
May 13, 2026
Faraz32123
reviewed
May 14, 2026
Comment on lines
119
to
136
| for mfe in indigo_styled_mfes: | ||
| hooks.Filters.ENV_PATCHES.add_items( | ||
| [ | ||
| ( | ||
| f"mfe-dockerfile-post-npm-install-{mfe}", | ||
| """ | ||
| RUN npm install '@edx/brand@github:@edly-io/brand-openedx#indigo-2.5.2' | ||
| """, # noqa: E501 | ||
| ), | ||
| ] | ||
| ) | ||
|
|
||
| hooks.Filters.ENV_PATCHES.add_item( | ||
| ( | ||
| "mfe-dockerfile-post-npm-install-authn", | ||
| "RUN npm install '@edx/brand@github:@edly-io/brand-openedx#indigo-2.5.2'", | ||
| ) | ||
| ) |
Collaborator
There was a problem hiding this comment.
Can we update brand version as well?
Collaborator
Author
There was a problem hiding this comment.
Brand version updated from 2.5.2 to 2.5.3.
Faraz32123
reviewed
May 14, 2026
Comment on lines
+125
to
+134
| @@ -131,7 +131,7 @@ def _override_openedx_docker_image( | |||
| hooks.Filters.ENV_PATCHES.add_item( | |||
| ( | |||
| "mfe-dockerfile-post-npm-install-authn", | |||
| "RUN npm install '@edx/brand@github:@edly-io/brand-openedx#indigo-2.5.2'", | |||
| "RUN npm install '@edx/brand@github:@edly-io/brand-openedx#indigo-2.5.3'", | |||
Collaborator
There was a problem hiding this comment.
indigo-2.5.3 was for release(ulmo) branch created 2 days ago. Whereas our PR is merged yesterday.
It just came to my mind, can we revert our brand PR and create a new branch named verawood/indigo and commit our changes there. And from that branch, create a new release indigo-2.6.0 and use that here.
Collaborator
Author
There was a problem hiding this comment.
Brand version updated from 2.5.3 to 3.0.0. The release 3.0.0 is created from the latest verawood/indigo branch.
Faraz32123
reviewed
May 14, 2026
Comment on lines
+346
to
+357
| "url": "https://cdn.jsdelivr.net/gh/edly-io/brand-openedx@ulmo/indigo/dist/core.min.css", | ||
| }, | ||
| "defaults": { | ||
| "light": "light", | ||
| "dark": "dark", | ||
| }, | ||
| "variants": { | ||
| "light": { | ||
| "url": "https://cdn.jsdelivr.net/gh/edly-io/brand-openedx@ulmo/indigo/dist/light.min.css", | ||
| }, | ||
| "dark": { | ||
| "url": "https://cdn.jsdelivr.net/gh/edly-io/brand-openedx@ulmo/indigo/dist/dark.min.css", |
Collaborator
There was a problem hiding this comment.
can we please also change the branch name form ulmo/indigo to verawoord/indigo here.
Pull each Indigo plugin slot config into a single (slot_name, jsx) tuple constant, deduplicating the per-MFE PLUGIN_SLOTS entries via splat, and register each one with FRONTEND_COMPAT_SLOTS so they also apply under frontend-base. Also install the Indigo brand on the new frontend-base site shell, temporarily pointing brand installs at an alternate source until @edly-io/indigo-brand-openedx is updated. Co-Authored-By: Claude <noreply@anthropic.com>
Preserves global application of these contributions under the new per-MFE compat-slots signature. Co-Authored-By: Claude <noreply@anthropic.com>
arbirali
force-pushed
the
frontend-base-compat-indigo
branch
from
May 14, 2026 11:58
6927d1f to
cae4ac3
Compare
ahmed-arb
approved these changes
May 14, 2026
github-project-automation
Bot
moved this from In review
to Done
in Tutor project management
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the Indigo theme to align with the new styling mechanism introduced in openedx/frontend-base.
Previously, styling in MFEs relied on build-time CSS imports. However, with the introduction of runtime configuration in frontend-base, global styles (including Paragon and theme overrides) are now injected dynamically into the document via PARAGON_THEME_URLS.
This change ensures that Indigo correctly provides its theme styles using the runtime configuration approach, allowing consistent branding across all MFEs without requiring rebuilds.
There is a related PR in the brand-openedx #58
How Has This Been Tested
Learner Dashboard
Authn
Profile