[tests-only][full-ci] Add tests for share expiry #10935
Open
+80
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amrita-shrestha
force-pushed
the
add-test-for-share-expiry-notification
branch
3 times, most recently
from
ffa135a to
0aa56bb
Compare
amrita-shrestha
requested review from
anon-pradip,
saw-jan,
Salipa-Gurung,
nabim777,
S-Panta and
nirajacharya2
24 tasks
amrita-shrestha
force-pushed
the
add-test-for-share-expiry-notification
branch
3 times, most recently
from
add3c55 to
c1778d1
Compare
anon-pradip
reviewed
Jan 28, 2025
tests/acceptance/features/apiSettings/notificationSetting.feature
Outdated
Show resolved
Hide resolved
amrita-shrestha
changed the title
|
|
amrita-shrestha
force-pushed
the
add-test-for-share-expiry-notification
branch
5 times, most recently
from
173fdf5 to
7a4f94b
Compare
amrita-shrestha
force-pushed
the
add-test-for-share-expiry-notification
branch
4 times, most recently
from
db49698 to
8537813
Compare
saw-jan
reviewed
Feb 5, 2025
tests/acceptance/features/apiSettings/notificationSetting.feature
Outdated
Show resolved
Hide resolved
saw-jan
reviewed
Feb 5, 2025
tests/acceptance/features/apiSettings/notificationSetting.feature
Outdated
Show resolved
Hide resolved
amrita-shrestha
force-pushed
the
add-test-for-share-expiry-notification
branch
from
8537813 to
40e57b6
Compare
amrita-shrestha
force-pushed
the
add-test-for-share-expiry-notification
branch
3 times, most recently
from
64670d2 to
c658fc3
Compare
|
|
amrita-shrestha
force-pushed
the
add-test-for-share-expiry-notification
branch
from
c658fc3 to
590d199
Compare
amrita-shrestha
force-pushed
the
add-test-for-share-expiry-notification
branch
from
590d199 to
a0612ce
Compare
9 tasks
amrita-shrestha
force-pushed
the
add-test-for-share-expiry-notification
branch
2 times, most recently
from
fa0478f to
22db1e1
Compare
saw-jan
requested changes
Feb 11, 2025
| Then the HTTP status code should be "200" | ||
| And user "Brian" should get a notification with subject "Membership expired" and message: | ||
| | message | | ||
| | Access to Space Alice Hansen lost | |
There was a problem hiding this comment.
Access to Space Alice Hansen lost
the message doesn't seem to align with the action. It should similar to Access to testfile.txt expired
There was a problem hiding this comment.
did you forget our last discussion regarding this current behavior,. I have raise question on bug report but no reply came, so assuming this current behavior, scenario has been written.
Don't forget to ask directly to developer in standup, if you want instant reply 😄
There was a problem hiding this comment.
then we should not merge this PR until the expected behavior is confirmed
tests/acceptance/features/apiNotification/shareExpireNotification.feature
Show resolved
Hide resolved
tests/acceptance/features/apiNotification/shareExpireNotification.feature
Outdated
Show resolved
Hide resolved
amrita-shrestha
force-pushed
the
add-test-for-share-expiry-notification
branch
3 times, most recently
from
9274926 to
65aab48
Compare
amrita-shrestha
force-pushed
the
add-test-for-share-expiry-notification
branch
from
65aab48 to
81f521b
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR add tests for checking in-app and mail notification alert for resource share expiry of personal .
I tried two approach
And the fields of the last response to user "Alice" should includeand strict expiration date is not possible in simple wayFlakiness Alert
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: