fix: signed urls, stronger hash #11292
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mklos-kw
force-pushed
the
chore/cs-1
branch
4 times, most recently
from
cc67c4d to
8e00674
Compare
|
mklos-kw
commented
May 8, 2025
| avg := took.Milliseconds() / int64(N) | ||
| // Key iterations: 10000, ~2 ms local, ~5ms CI | ||
| // Key iterations: 256*1024, ~73 ms local, ~154ms CI | ||
| assert.Less(t, avg, int64(100)) |
There was a problem hiding this comment.
The acceptance download timeout in 30s may be related to iterations increase: pua.createSignature takes x30 longer. Noticeable impact for users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Security update to signed URLs, using stronger keys now.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: