test: pass timeout_msec through to waitTillElementIsNotNull on VerificationPage#335
Open
phil-davis wants to merge 1 commit into
Open
test: pass timeout_msec through to waitTillElementIsNotNull on VerificationPage#335phil-davis wants to merge 1 commit into
phil-davis wants to merge 1 commit into
Conversation
…cationPage The timeout_msec parameter to waitTillPageIsLoaded was being ignored. Now it is passed on. A few other minor grammar changes were also made.
Contributor
Author
|
There might be some interaction with the strict checking of the guest app whitelist that was merged in the guests app a few days ago: I will investigate locally. |
individual-it
approved these changes
Jul 11, 2026
There was a problem hiding this comment.
Pull request overview
This PR fixes an acceptance-test page-object behavior where the timeout_msec argument on VerificationPage::waitTillPageIsLoaded() was previously ignored, by passing that timeout through to the underlying element-wait helper. It also includes a couple of small grammar/spelling corrections in acceptance-test assets.
Changes:
- Pass
timeout_msecthrough towaitTillElementIsNotNull()inVerificationPage::waitTillPageIsLoaded(). - Fix typo in a Gherkin scenario name (“mutiple” → “multiple”).
- Adjust docblock wording (“two factor” → “two-factor”).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/acceptance/features/webUIcliTwoFactorTOTP/deleteSecret.feature | Fixes a scenario title typo to improve readability of acceptance specs. |
| tests/acceptance/features/lib/VerificationPage.php | Ensures timeout_msec is honored by passing it to the element wait helper. |
| tests/acceptance/features/bootstrap/TwoFactorTOTPContext.php | Minor docblock grammar update. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The timeout_msec parameter to waitTillPageIsLoaded was being ignored. Now it is passed on.
A few other minor grammar changes were also made.