Skip to content

test: pass timeout_msec through to waitTillElementIsNotNull on VerificationPage #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
phil-davis wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −3
Open

test: pass timeout_msec through to waitTillElementIsNotNull on VerificationPage #335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/acceptance/features/bootstrap/TwoFactorTOTPContext.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ public function theSecretCodeFromQRCodeShouldMatchWithTheOneDisplayedOnTheWebUI(
}

/**
* Send request with secret key for two factor authentication
* Send request with secret key for two-factor authentication
*
* @param string $user
* @param string $secretKey
Expand Down
5 changes: 4 additions & 1 deletion tests/acceptance/features/lib/VerificationPage.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,10 @@ public function waitTillPageIsLoaded(
Session $session,
int $timeout_msec = STANDARD_UI_WAIT_TIMEOUT_MILLISEC
): void {
$field = $this->waitTillElementIsNotNull($this->verificationFieldXpath);
$field = $this->waitTillElementIsNotNull(
$this->verificationFieldXpath,
$timeout_msec
);
$this->assertElementNotNull(
$field,
__METHOD__ . ' Field for adding verification code could not be found'
Expand Down
2 changes: 1 addition & 1 deletion tests/acceptance/features/webUIcliTwoFactorTOTP/deleteSecret.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ Feature: Use the CLI to delete secrets for users
And the command output should contain the text "1 secrets deleted for Alice"
And user "Alice" using password "%regularuser%" should not be able to download file "textfile0.txt"

Scenario: Delete secrets for mutiple users
Scenario: Delete secrets for multiple users
Given user "Alice" has logged in using the webUI
And the user has browsed to the personal security settings page
And the user has activated TOTP Second-factor auth but not verified
Expand Down
Loading