Reopen named files also before saving #470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
The underlying file could have been deleted or replaced and its inode may be different, reopening it just before writing should ensure the content is written where it's supposed to. Signed-off-by: Nikola Forró <[email protected]>
Contributor
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 58s |
mfocko
approved these changes
May 15, 2025
Signed-off-by: Nikola Forró <[email protected]>
Contributor
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 56s |
Contributor
|
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 1m 58s |
softwarefactory-project-zuul
bot
merged commit 99747cf
into
main
39 of 40 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying file could have been deleted or replaced and its inode may be different, reopening it just before writing should ensure the content is written where it's supposed to.