Skip to content

fix(deps): pact-ffi 0.5.5 - #588

Closed
YOU54F wants to merge 6 commits into
masterfrom
fix/pact-ffi-0.5.5
Closed

fix(deps): pact-ffi 0.5.5#588
YOU54F wants to merge 6 commits into
masterfrom
fix/pact-ffi-0.5.5

Conversation

@YOU54F

@YOU54F YOU54F commented Jul 31, 2026

Copy link
Copy Markdown
Member

No description provided.

@mefellows

Copy link
Copy Markdown
Member

Ah, needs to the change to use the updated servers. I thought I had done this already somewhere 🤔

@YOU54F

YOU54F commented Jul 31, 2026

Copy link
Copy Markdown
Member Author

yeah no worries, on it now. will be a breaking change as create mock server for pact is gone and pact verify with args also gone.

create mock server without transport can default to http, and split address into address and port. not sure what the equiv tls flag is in config

@YOU54F

YOU54F commented Aug 3, 2026

Copy link
Copy Markdown
Member Author

So there is an error in the https tests on the mock server side

=== RUN   TestConsumerV2
2026/07/31 15:27:30 [DEBUG] pact setup
2026/07/31 15:27:30 [DEBUG] initialising native interface
2026/07/31 15:27:30 [DEBUG] initialised native log level to TRACE (5)
2026/07/31 15:27:30 [DEBUG] initialised native log to log to stdout
2026/07/31 15:27:30 [DEBUG] log_to_stdout res -1
2026/07/31 15:27:30 [ERROR] failed to log to stdout: can't set logger (applying the logger failed, perhaps because one is applied already).
2026/07/31 15:27:30 [DEBUG] pact add V2 interaction
2026/07/31 15:27:30 [DEBUG] pact verify
2026/07/31 15:27:30 [DEBUG] mock server starting on address: 127.0.0.1:0
2026/07/31 15:27:30 [DEBUG] parsed host: 127.0.0.1 port: 0

thread '<unnamed>' (6086151) panicked at /Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/rustls-0.23.43/src/crypto/mod.rs:249:14:

Could not automatically determine the process-level CryptoProvider from Rustls crate features.
Call CryptoProvider::install_default() before this point to select a provider manually, or make sure exactly one of the 'aws-lc-rs' and 'ring' features is enabled.
See the documentation of the CryptoProvider type for more information.
            
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Caught panic with error: 
Could not automatically determine the process-level CryptoProvider from Rustls crate features.
Call CryptoProvider::install_default() before this point to select a provider manually, or make sure exactly one of the 'aws-lc-rs' and 'ring' features is enabled.
See the documentation of the CryptoProvider type for more information.
            
2026/07/31 15:27:30 [DEBUG] mock server cleaning up port: 0

thread '<unnamed>' (6086151) panicked at pact_ffi/src/mock_server/handles.rs:246:43:
called `Result::unwrap()` on an `Err` value: PoisonError { .. }
Caught panic with error: called `Result::unwrap()` on an `Err` value: PoisonError { .. }
2026/07/31 15:27:30 [DEBUG] pact setup

thread '<unnamed>' (6086151) panicked at pact_ffi/src/mock_server/handles.rs:218:45:
called `Result::unwrap()` on an `Err` value: PoisonError { .. }

thread '<unnamed>' (6086151) panicked at /rustc/8bab26f4f68e0e26f0bb7960be334d5b520ea452/library/core/src/panicking.rs:225:5:
panic in a function that cannot unwind
stack backtrace:
   0:        0x107536b40 - _pactffi_write_pact_file
   1:        0x10754e024 - _pactffi_write_pact_file
   2:        0x10753d280 - _pactffi_write_pact_file
   3:        0x10751b4d0 - _pactffi_write_pact_file
   4:        0x10752f7f8 - _pactffi_write_pact_file
   5:        0x10752fb20 - _pactffi_write_pact_file
   6:        0x10751b590 - _pactffi_write_pact_file
   7:        0x107510888 - _pactffi_write_pact_file
   8:        0x10751c040 - _pactffi_write_pact_file
   9:        0x107572e84 - _pactffi_write_pact_file
  10:        0x107572e0c - _pactffi_write_pact_file
  11:        0x107572f60 - _pactffi_write_pact_file
  12:        0x106e13418 - _pactffi_new_pact
  13:        0x1034098b0 - __cgo_916567ef4fd7_Cfunc_pactffi_new_pact
thread caused non-unwinding panic. aborting.
SIGABRT: abort
PC=0x186d325e8 m=4 sigcode=0
signal arrived during cgo execution

Same issue was seen in the pact_ffi tests

pact-foundation/pact-reference@bdfe6f6#diff-d6fdf640e7952e605d5a425978e18d3aa2606501c1b9743426f76dc5989178daR2564-R2570

This is where we are setting it I believe

pact-foundation/pact-core-mock-server@9b86e78

@YOU54F

YOU54F commented Aug 3, 2026

Copy link
Copy Markdown
Member Author

^ cc @rholshausen / @JP-Ellis / @mefellows

@JP-Ellis

JP-Ellis commented Aug 3, 2026

Copy link
Copy Markdown
Member

I discovered this https issue while upgrading the FFI in Pact JS 😅

Created the ticket to track this, I'll look into it tomorrow

@rholshausen

Copy link
Copy Markdown
Contributor

FYI: pact-foundation/pact-reference#543

@mefellows

Copy link
Copy Markdown
Member

@YOU54F I remember where I added the mock server changes now: #573

Let's get this solved, then we can merge the other.

@YOU54F

YOU54F commented Aug 4, 2026

Copy link
Copy Markdown
Member Author

Ah, needs to the change to use the updated servers. I thought I had done this already somewhere 🤔

found it! adding the external interaction ref

https://github.com/pact-foundation/pact-go/tree/add-external-reference

@YOU54F

YOU54F commented Aug 4, 2026

Copy link
Copy Markdown
Member Author

hah jinx!

@YOU54F
YOU54F force-pushed the fix/pact-ffi-0.5.5 branch from 0216ddb to f52dcd6 Compare August 5, 2026 13:56
@coveralls

coveralls commented Aug 5, 2026

Copy link
Copy Markdown

Coverage Status

coverage: 28.264% (-0.1%) from 28.36% — fix/pact-ffi-0.5.5 into master

@YOU54F
YOU54F requested a review from mefellows August 5, 2026 14:56
@YOU54F

YOU54F commented Aug 5, 2026

Copy link
Copy Markdown
Member Author

Good for re-review now :)

@mefellows

Copy link
Copy Markdown
Member

Superseded by #592 (review).

@mefellows mefellows closed this Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants