Skip to content

Feat/add external reference - #592

Merged
mefellows merged 9 commits into
masterfrom
feat/add-external-reference
Aug 6, 2026
Merged

Feat/add external reference#592
mefellows merged 9 commits into
masterfrom
feat/add-external-reference

Conversation

@YOU54F

@YOU54F YOU54F commented Aug 5, 2026

Copy link
Copy Markdown
Member

supersedes #573

drops tls proxy being created and started in pact-go (added in the above pr)

includes #588

@YOU54F
YOU54F requested review from mefellows and rholshausen August 5, 2026 14:56
@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 28.569% (+0.2%) from 28.36% — feat/add-external-reference into master

@rholshausen rholshausen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't really comment on go code, it looks like go code, but the coverage is up 0.2% so it must be good

@mefellows
mefellows merged commit 67d51c1 into master Aug 6, 2026
16 checks passed
@mefellows
mefellows deleted the feat/add-external-reference branch August 6, 2026 01:10
@mefellows

Copy link
Copy Markdown
Member

Looks good - thanks for going through all the lints as well. Good to clean house with removing some of the old functions too. I'll close off the related PRs if they haven't been done already.

@YOU54F

YOU54F commented Aug 6, 2026

Copy link
Copy Markdown
Member Author

Hmm looks like release failed due to commit message from merge

❯ targetBranch: master
❯ commit could not be parsed: 67d51c1d36fcb059b183f2c642a9c8217c59c1e1 Feat/add external reference (#592)
❯ error message: Error: unexpected token ' ' at 1:9, valid tokens [(, !, :]
❯ commits: 0
✔ Considering: 0 commits
✔ No commits for path: ., skipping

@mefellows

mefellows commented Aug 6, 2026

Copy link
Copy Markdown
Member

Yeah I noticed that, it was on the TODO to look at. I think we need to do two things

  1. Add a pre-merge check to ensure the commits match semantic conventions
  2. Get another change in to do a release, and manually update the changelog to incorporate the items that it didn't like

YOU54F added a commit that referenced this pull request Aug 6, 2026
YOU54F added a commit that referenced this pull request Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants