Feat/add external reference - #592
Merged
Merged
Conversation
CreateMockServer (for pact), use StartTransport preferred of Start Verifier.Verify (via args+), use VerifyProvider
Agent-Logs-Url: https://github.com/pact-foundation/pact-go/sessions/5279a831-3944-43f9-96ac-533cfda80779 Co-authored-by: mefellows <53900+mefellows@users.noreply.github.com>
rholshausen
approved these changes
Aug 5, 2026
rholshausen
left a comment
Contributor
There was a problem hiding this comment.
Can't really comment on go code, it looks like go code, but the coverage is up 0.2% so it must be good
Member
|
Looks good - thanks for going through all the lints as well. Good to clean house with removing some of the old functions too. I'll close off the related PRs if they haven't been done already. |
This was referenced Aug 6, 2026
Member
Author
|
Hmm looks like release failed due to commit message from merge |
Member
|
Yeah I noticed that, it was on the TODO to look at. I think we need to do two things
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
supersedes #573
drops tls proxy being created and started in pact-go (added in the above pr)
includes #588