chore(pact_models): use neutral values in arrayContains expression tests - #542
Merged
rholshausen merged 1 commit intoJul 28, 2026
Conversation
The arrayContains tests I added in pact-foundation#523 used string constants taken from my employer's product domain. They carry no meaning here, so swap them for neutral book-format values. Test data only -- assertions, coverage and parser behaviour are unchanged. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
arrayContainstests I added in #523 used string constants taken straight from my employer's product domain. They carry no meaning in this crate and shouldn't have gone upstream.Swapped for neutral book-format values throughout
rust/pact_models/src/matchingrules/expressions.rs(exact before/after in the diff): the twoequalTosample values become'HARDCOVER'and'PAPERBACK', and the regex test uses the pattern'HARDCOVER|PAPER.*'.Test data only — assertions, coverage and parser behaviour are unchanged.
Note these strings are already published in
pact_models1.3.10 and 1.3.11, so this only cleans things up going forward. No urgency from my side.Verification
cargo test --lib matchingrules::expressions— 63 passed, 0 failed.