Skip to content

Conversation

christian-calabrese
Copy link
Contributor

In local modules, providers versions are inherited from the root module. Displaying them in the READMEs is causing issues in static analysis due to inconsistent results.

@christian-calabrese christian-calabrese requested a review from a team as a code owner October 16, 2025 15:06
Copy link

changeset-bot bot commented Oct 16, 2025

⚠️ No Changeset found

Latest commit: eb8e1cc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

📋 Pre-commit Output Log
[INFO] Initializing environment for https://github.com/antonbabenko/pre-commit-terraform.
Lock Terraform Registry modules..................................(no files to check)Skipped
Terraform Providers Lock (on staged .terraform.lock.hcl files).......................Passed
- hook id: terraform_providers_lock_staged
- duration: 0.08s

No .terraform.lock.hcl files to process.

Terraform fmt....................................................(no files to check)Skipped
terraform_docs on modules............................................................Passed
terraform_docs on resources......................................(no files to check)Skipped
Terraform validate with tflint...................................(no files to check)Skipped
Terraform validate...............................................(no files to check)Skipped
Terraform validate with trivy....................................(no files to check)Skipped

Generated on Thu Oct 16 16:24:08 UTC 2025
Run all checks on modified files

Copy link
Contributor

Tip

✅ All Terraform module locks are up to date

No module changes detected - everything is in sync!

📋 Pre-commit Output Log
[INFO] Initializing environment for https://github.com/antonbabenko/pre-commit-terraform.
Lock Terraform Registry modules..........................................Passed

Generated on Thu Oct 16 16:24:14 UTC 2025
Run lock_modules on folder: infra/resources//prod/

Copy link
Contributor

Tip

✅ All Terraform module locks are up to date

No module changes detected - everything is in sync!

📋 Pre-commit Output Log
[INFO] Initializing environment for https://github.com/antonbabenko/pre-commit-terraform.
Lock Terraform Registry modules..........................................Passed

Generated on Thu Oct 16 16:24:21 UTC 2025
Run lock_modules on folder: infra/resources//dev/

Copy link
Contributor

📖 Terraform Plan (infra/resources//prod) - success

Show Plan
  # module.dx_website.azurerm_static_web_app_custom_domain.this has changed
  ~ resource "azurerm_static_web_app_custom_domain" "this" {
        id                = "/subscriptions/02a23258-2e41-433c-8e9a-465b99e77bca/resourceGroups/dx-p-itn-common-rg-01/providers/Microsoft.Web/staticSites/dx-p-itn-website-stapp-01/customDomains/dx.pagopa.it"
      - validation_token  = (sensitive value) -> null
        # (3 unchanged attributes hidden)
    }


Unless you have made equivalent changes to your configuration, or ignored the
relevant attributes using ignore_changes, the following plan may include
actions to undo or respond to these changes.

─────────────────────────────────────────────────────────────────────────────

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # module.dx_website.azurerm_dns_txt_record.validation will be updated in-place
  ~ resource "azurerm_dns_txt_record" "validation" {
        id                  = "/subscriptions/02a23258-2e41-433c-8e9a-465b99e77bca/resourceGroups/dx-p-itn-network-rg-01/providers/Microsoft.Network/dnsZones/dx.pagopa.it/TXT/_dnsauth.dx.pagopa.it"
        name                = "_dnsauth.dx.pagopa.it"
        tags                = {}
        # (4 unchanged attributes hidden)

      - record {
          # At least one attribute in this block is (or was) sensitive,
          # so its contents will not be displayed.
        }
      + record {
          # At least one attribute in this block is (or was) sensitive,
          # so its contents will not be displayed.
        }
    }

  # module.dx_website.azurerm_static_web_app.this will be updated in-place
  ~ resource "azurerm_static_web_app" "this" {
        id                                 = "/subscriptions/02a23258-2e41-433c-8e9a-465b99e77bca/resourceGroups/dx-p-itn-common-rg-01/providers/Microsoft.Web/staticSites/dx-p-itn-website-stapp-01"
        name                               = "dx-p-itn-website-stapp-01"
      - repository_branch                  = "main" -> null
      - repository_url                     = "https://github.com/pagopa/dx" -> null
      ~ sku_tier                           = "Standard" -> "Free"
        tags                               = {
            "CostCenter"     = "TS000 - Tecnologia e Servizi"
            "CreatedBy"      = "Terraform"
            "Environment"    = "Prod"
            "ManagementTeam" = "Developer Experience"
            "Owner"          = "DevEx"
            "Source"         = "https://github.com/pagopa/dx/blob/main/infra/resources/prod"
        }
        # (10 unchanged attributes hidden)
    }

Plan: 0 to add, 2 to change, 0 to destroy.

Copy link
Contributor

📖 Terraform Plan (infra/resources//dev) - failure

Show Plan

Terraform plan execution failed. Check the workflow logs for full details.

Copy link
Contributor

@gunzip gunzip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. but CI doesnt pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants