fix(IT-Wallet): [SIW-3282] Fix back navigation in eID reissuance actions#7812
fix(IT-Wallet): [SIW-3282] Fix back navigation in eID reissuance actions#7812DavideOnano wants to merge 3 commits intomasterfrom
Conversation
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7812 +/- ##
==========================================
- Coverage 60.34% 58.16% -2.18%
==========================================
Files 1938 1934 -4
Lines 42815 42770 -45
Branches 9817 9873 +56
==========================================
- Hits 25836 24878 -958
- Misses 16900 17805 +905
- Partials 79 87 +8
... and 102 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
mastro993
left a comment
There was a problem hiding this comment.
On the Failure screen, the "Cancel" CTA navigates back instead of closing the issuance flow.
| if (navigation.canGoBack()) { | ||
| navigation.goBack(); | ||
| return; | ||
| } |
There was a problem hiding this comment.
The solution works.
However, this change removes the ability to display the feedback sheet, which is currently triggered by the requiredEidFeedback parameter.
We have two possible approaches:
- Move the logic to the Redux store.
- Let the screen that triggers the close also manage the feedback bottom sheet directly.
Both options require some UX decisions before proceeding. I suggest we align on this during the next sync.
What do you think?
There was a problem hiding this comment.
Yes i think we can hande this at screen level because it keeps navigation/UI concerns local and avoid adding global state, maybe is better.
Let’s talk about this in the next sync, thank you!
Ignore this. The "close" button of the CIE failure screen does not trigger the "closeIssuance" action. |
Short description
Updated
closeIssuanceto try a back navigation when closing a reissuance flow, instead of always resetting to Wallet. This preserves the originating stack when available.List of changes proposed in this pull request
navigation.goBack()action incloseIssuanceto return to the previous stack during reissuance (if available).How to test