Skip to content

fix(IT-Wallet): [SIW-3282] Fix back navigation in eID reissuance actions#7812

Open
DavideOnano wants to merge 3 commits intomasterfrom
SIW-3282/fix-back-navigation-l3-survey
Open

fix(IT-Wallet): [SIW-3282] Fix back navigation in eID reissuance actions#7812
DavideOnano wants to merge 3 commits intomasterfrom
SIW-3282/fix-back-navigation-l3-survey

Conversation

@DavideOnano
Copy link
Collaborator

Short description

Updated closeIssuance to try a back navigation when closing a reissuance flow, instead of always resetting to Wallet. This preserves the originating stack when available.

List of changes proposed in this pull request

  • Added a navigation.goBack() action in closeIssuance to return to the previous stack during reissuance (if available).

How to test

  • Start a reissuance flow from Messaggi section.
  • Reach the identification screen, press “Back,” and confirm dismissal.
  • Verify you return to the Messaggi stack (not Portafoglio).
  • Start a reissuance flow from Portafoglio section and repeat to verify it returns correctly to Portafoglio.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 28, 2026

Jira Pull Request Link

This Pull Request refers to Jira issues:

@github-actions
Copy link
Contributor

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

@codecov
Copy link

codecov bot commented Jan 28, 2026

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.16%. Comparing base (c405003) to head (aa8590a).

Files with missing lines Patch % Lines
ts/features/itwallet/machine/eid/actions.ts 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7812      +/-   ##
==========================================
- Coverage   60.34%   58.16%   -2.18%     
==========================================
  Files        1938     1934       -4     
  Lines       42815    42770      -45     
  Branches     9817     9873      +56     
==========================================
- Hits        25836    24878     -958     
- Misses      16900    17805     +905     
- Partials       79       87       +8     
Files with missing lines Coverage Δ
ts/features/itwallet/machine/eid/actions.ts 0.91% <0.00%> (-0.03%) ⬇️

... and 102 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c405003...aa8590a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DavideOnano DavideOnano self-assigned this Jan 29, 2026
Copy link
Contributor

@mastro993 mastro993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the Failure screen, the "Cancel" CTA navigates back instead of closing the issuance flow.

Comment on lines +238 to +241
if (navigation.canGoBack()) {
navigation.goBack();
return;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The solution works.

However, this change removes the ability to display the feedback sheet, which is currently triggered by the requiredEidFeedback parameter.

We have two possible approaches:

  • Move the logic to the Redux store.
  • Let the screen that triggers the close also manage the feedback bottom sheet directly.

Both options require some UX decisions before proceeding. I suggest we align on this during the next sync.

What do you think?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes i think we can hande this at screen level because it keeps navigation/UI concerns local and avoid adding global state, maybe is better.
Let’s talk about this in the next sync, thank you!

@mastro993
Copy link
Contributor

On the Failure screen, the "Cancel" CTA navigates back instead of closing the issuance flow.

Ignore this. The "close" button of the CIE failure screen does not trigger the "closeIssuance" action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants