Skip to content

fix(IT-Wallet): [SIW-3282] Fix back navigation in eID reissuance actions #7812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DavideOnano wants to merge 3 commits into
base: master
Choose a base branch
from
+4 −0
Open

fix(IT-Wallet): [SIW-3282] Fix back navigation in eID reissuance actions #7812

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
72cd89c
fix: implement back navigation in eID reissuance actions
DavideOnano Jan 28, 2026
eae2b6d
delete check on reissuance for back navigation
DavideOnano Jan 29, 2026
aa8590a
Merge branch 'master' into SIW-3282/fix-back-navigation-l3-survey
mastro993 Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ts/features/itwallet/machine/eid/actions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,10 @@ export const createEidIssuanceActionsImplementation = (
closeIssuance: ({
context
}: ActionArgs<Context, EidIssuanceEvents, EidIssuanceEvents>) => {
if (navigation.canGoBack()) {
navigation.goBack();
return;
}
Comment on lines +238 to +241
Copy link
Contributor

@mastro993 mastro993 Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The solution works.

However, this change removes the ability to display the feedback sheet, which is currently triggered by the requiredEidFeedback parameter.

We have two possible approaches:

  • Move the logic to the Redux store.
  • Let the screen that triggers the close also manage the feedback bottom sheet directly.

Both options require some UX decisions before proceeding. I suggest we align on this during the next sync.

What do you think?

Copy link
Collaborator Author

@DavideOnano DavideOnano Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes i think we can hande this at screen level because it keeps navigation/UI concerns local and avoid adding global state, maybe is better.
Let’s talk about this in the next sync, thank you!

navigation.reset({
index: 1,
routes: [
Expand Down
Loading