fix(model): rename JournalPageType.attachement → attachment (#221) - #222
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ctor (#199) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…uture fields Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…rtup call site
Eliminates the domain model typo from enum definition, all consumers, method signature (injectAttachmentLinks), log strings, comments, and plan prose. grep -rn "attachement" src/ returns zero hits. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
pajoma
force-pushed
the
fix/221-attachement-typo
branch
from
May 18, 2026 17:20
63badf7 to
8dbcb57
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JournalPageType.attachement→JournalPageType.attachmentin the core domain enumSyncNoteLinks.injectAttachementLinks→injectAttachmentLinks(method + 3 log strings)startup.ts, consumers inpaths.tsanddialogues.ts, comments inscan-entries.ts, and plan prose indocs/plans/2026-05-18-199-infer-type-context-object.mdVerification
grep -rn "attachement" src/→ zero hitsnpm run compile→ clean build, zero TS errorsReferences
Test plan
grep -rn "attachement" src/returns zero hitsnpm run compileexits clean🤖 Generated with Claude Code