add delete button on details and edit views#2733
Open
samialfattani wants to merge 2 commits into
Open
Conversation
Contributor
Would it make sense to have the Delete button next to the "Cancel" one rather than on the top?
|
Contributor
Author
I thought about that, but i found it more clear to have it on the top for many reasons: |
Contributor
|
I think having the delete button in the bottom row with existing buttons sounds good. We could right align it to create distance. If it doesn't already, the delete process could also require a confirmation step to prevent accidental deletion. |
Contributor
Author
|
waht about details page ? 
|
This comment was marked as resolved.
This comment was marked as resolved.
Fixes pallets-eco#1327 fix showing confirm message on Modal Align "Delete" button with other button groups in Edit page fix
samialfattani
force-pushed
the
feat/delete-btn2
branch
from
4c860c9 to
dfd324a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1327
Tests case are added to make sure button is appeared in both edit and details views with both Modal and non-modal mode