Skip to content

Conversation

@samialfattani
Copy link
Contributor

Fixes #1327

Tests case are added to make sure button is appeared in both edit and details views with both Modal and non-modal mode

@samialfattani samialfattani marked this pull request as ready for review December 26, 2025 15:52
@ElLorans
Copy link
Contributor

ElLorans commented Jan 1, 2026

image Would it make sense to have the Delete button next to the "Cancel" one rather than on the top?

@samialfattani
Copy link
Contributor Author

Would it make sense to have the Delete button next to the "Cancel" one rather than on the top?

I thought about that, but i found it more clear to have it on the top for many reasons:
1- keep it far away of cancel button to avoid clicking delete by mistake.
2- when i was trying to add the button in Modal pages, it was'nt strait forward and i found some issues with JS.

@samuelhwilliams
Copy link
Contributor

I think having the delete button in the bottom row with existing buttons sounds good. We could right align it to create distance. If it doesn't already, the delete process could also require a confirmation step to prevent accidental deletion.

@samialfattani
Copy link
Contributor Author

samialfattani commented Jan 3, 2026

waht about details page ?

image

I think having the delete button in the bottom row with existing buttons sounds good. We could right align it to create distance. If it doesn't already, the delete process could also require a confirmation step to prevent accidental deletion.

Why we can't place "Delete" beside "Save" ?

Thnx for your comment, but I have reviewed the source code, and it seems like it is NOT possible to have the button aligned with others because of the **<form> ** tag Since Delete button should be wrapped in a separate <form> it can not be placed beside the "Save" buttons because they are already wrapped by thier <form> that include all Edit fields including "save" and other extra buttons. If i put the delete button beside "save" it will be like <form> inside another <form> which is not accepted case in HTML

@samialfattani

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Delete button on Edit/Detail view

3 participants