Skip to content

Run typechecking in CI again#637

Open
rnestler wants to merge 5 commits intopallets-eco:masterfrom
rnestler:improve-type-checks
Open

Run typechecking in CI again#637
rnestler wants to merge 5 commits intopallets-eco:masterfrom
rnestler:improve-type-checks

Conversation

@rnestler
Copy link
Copy Markdown
Contributor

@rnestler rnestler commented Apr 20, 2026

This enables type-checking during CI gain.

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@rnestler rnestler force-pushed the improve-type-checks branch from 3451de5 to dde8616 Compare April 20, 2026 08:25
@rnestler rnestler marked this pull request as ready for review April 20, 2026 08:31
Comment thread pyproject.toml
dependency_groups = ["typing"]
commands = [
["mypy"],
["pyright"],
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pyright currently shows quite some type checking errors. Since I don't have much experience with it I just removed it for now.

I think getting one type checker to run successfully in strict mode should be the first priority. Adding more afterwards can still be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant